Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1386917

Re: [PATCH 2/2] tty: serial: msm_serial add info message

Show all headers | View raw

On 4/25/2016 1:48 PM, Stephen Boyd wrote:
> On 04/23, Frank Rowand wrote:
>> From: Frank Rowand <frank.rowand@am.sony.com>
>>
>> Failure to enable DMA by the msm_serial driver is silent.
>> Add a message to report the failure.
>>
>> Signed-off-by: Frank Rowand <frank.rowand@am.sony.com>
>> ---
>>  drivers/tty/serial/msm_serial.c |    1 +
>>  1 file changed, 1 insertion(+)
>>
>> Index: b/drivers/tty/serial/msm_serial.c
>> ===================================================================
>> --- a/drivers/tty/serial/msm_serial.c
>> +++ b/drivers/tty/serial/msm_serial.c
>> @@ -170,6 +170,7 @@ rel_tx:
>>  	dma_release_channel(dma->chan);
>>  no_tx:
>>  	memset(dma, 0, sizeof(*dma));
>> +	dev_info(dev, "msm_serial: DMA not enabled\n");
>>  }
>>  
> 
> Wouldn't this print twice for TX and RX channels? I'd prefer we
> not print anything when this driver probes, just because it's a
> bunch of log spam that we don't really need.

This is in msm_request_tx_dma().  I should have made the message
"msm_serial: TX DMA not enabled\n" and added a similar message
to msm_request_rx_dma().

Then it could print twice, once for TX and once for RX. :-)
For my board it would print twice because both requests would
fail for the same reason.

Should I add it to msm_request_rx_dma() also, but make both
locations dev_debug() instead of dev_info()?

-Frank

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] tty: serial: msm_serial regression and add info message Frank Rowand <frowand.list@gmail.com> - 2016-04-23 19:20 +0200
  [PATCH 2/2] tty: serial: msm_serial add info message Frank Rowand <frowand.list@gmail.com> - 2016-04-23 19:20 +0200
    Re: [PATCH 2/2] tty: serial: msm_serial add info message Stephen Boyd <sboyd@codeaurora.org> - 2016-04-25 22:50 +0200
      Re: [PATCH 2/2] tty: serial: msm_serial add info message Frank Rowand <frowand.list@gmail.com> - 2016-04-25 23:40 +0200
        Re: [PATCH 2/2] tty: serial: msm_serial add info message Stephen Boyd <sboyd@codeaurora.org> - 2016-04-25 23:40 +0200
          Re: [PATCH 2/2] tty: serial: msm_serial add info message Frank Rowand <frowand.list@gmail.com> - 2016-04-26 02:50 +0200

csiph-web