Re: [PATCH] mm: SLAB freelist randomization

From	Andrew Morton <akpm@linux-foundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mm: SLAB freelist randomization
Date	2016-04-25 23:10 +0200
Message-ID	<rrVVw-3ZH-7@gated-at.bofh.it> (permalink)
References	(2 earlier) <rokpt-1JE-27@gated-at.bofh.it> <rokIO-1T9-9@gated-at.bofh.it> <rpjUn-8sp-47@gated-at.bofh.it> <rpnbA-2v9-13@gated-at.bofh.it> <rpnuX-2F6-49@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, 18 Apr 2016 12:52:30 -0700 Thomas Garnier <thgarnie@google.com> wrote:

> I agree, if we had a generic way to pass entropy across boots on all
> architecture that would be amazing. I will let the SLAB maintainers to
> decide on requiring CONFIG_ARCH_RANDOM or documenting it.

In our world, requiring that sort of attention from maintainers
requires a pretty active level of pinging, poking and harrassing ;)

I do think that if you stick with get_random_bytes_arch() then it need
a comment explaining why.

And I (still) don't think that get_random_bytes_arch() actually does
what you want - if CONFIG_ARCH_RANDOM isn't implemented then
get_random_bytes_arch() just fails.  IOW your statement "the arch
version that will fallback on get_random_bytes sub API in the worse
case" is a misconception?  There is no fallback.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] mm: SLAB freelist randomization Thomas Garnier <thgarnie@google.com> - 2016-04-15 19:30 +0200
  Re: [PATCH] mm: SLAB freelist randomization Andrew Morton <akpm@linux-foundation.org> - 2016-04-16 00:10 +0200
    Re: [PATCH] mm: SLAB freelist randomization Joe Perches <joe@perches.com> - 2016-04-16 00:30 +0200
      Re: [PATCH] mm: SLAB freelist randomization Thomas Garnier <thgarnie@google.com> - 2016-04-16 00:50 +0200
        Re: [PATCH] mm: SLAB freelist randomization Thomas Garnier <thgarnie@google.com> - 2016-04-18 18:10 +0200
          Re: [PATCH] mm: SLAB freelist randomization Laura Abbott <labbott@redhat.com> - 2016-04-18 21:40 +0200
            Re: [PATCH] mm: SLAB freelist randomization Thomas Garnier <thgarnie@google.com> - 2016-04-18 22:00 +0200
              Re: [PATCH] mm: SLAB freelist randomization Andrew Morton <akpm@linux-foundation.org> - 2016-04-25 23:10 +0200

csiph-web