Re: [PATCH 4/4] ARM: remove duplicate const qualifier

From	Eric Engestrom <eric.engestrom@imgtec.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/4] ARM: remove duplicate const qualifier
Date	2016-04-25 16:40 +0200
Message-ID	<rrPQ7-7se-43@gated-at.bofh.it> (permalink)
References	(1 earlier) <rrLt8-3Bp-19@gated-at.bofh.it> <rrM5Q-4ay-7@gated-at.bofh.it> <rrNbA-57Y-17@gated-at.bofh.it> <rrOhm-643-35@gated-at.bofh.it> <rrPwK-7gP-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Apr 25, 2016 at 10:12:16AM -0400, Nicolas Pitre wrote:
> Beware.
> 
> I added many of those exactly because gcc did not ignore them when 
> compiling with LTO where the lack of a const qualifier to qualify the 
> actual array content, and not only the reference to that content, 
> generated build errors due to section mismatches from the __initconst 
> annotation.

I believe the first `const` does that, without the need for a second.

> So this is a NAK from me unless you may confirm that LTO builds are 
> unaffected by your changes.

I can't confirm it (haven't tried), and don't care enough to do it :]
I guess I'm just dropping the patch then. Like I said, it can't hurt to
leave them in.

Cheers,
Eric

Thread

[PATCH 1/4] perf tools: remove duplicate const qualifier Eric Engestrom <eric.engestrom@imgtec.com> - 2016-04-25 11:50 +0200
  [PATCH 4/4] ARM: remove duplicate const qualifier Eric Engestrom <eric.engestrom@imgtec.com> - 2016-04-25 11:50 +0200
    Re: [PATCH 4/4] ARM: remove duplicate const qualifier Viresh Kumar <viresh.kumar@linaro.org> - 2016-04-25 12:00 +0200
    Re: [PATCH 4/4] ARM: remove duplicate const qualifier Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-04-25 12:00 +0200
      Re: [PATCH 4/4] ARM: remove duplicate const qualifier Eric Engestrom <eric.engestrom@imgtec.com> - 2016-04-25 12:40 +0200
        Re: [PATCH 4/4] ARM: remove duplicate const qualifier Arnd Bergmann <arnd@arndb.de> - 2016-04-25 13:50 +0200
          Re: [PATCH 4/4] ARM: remove duplicate const qualifier Eric Engestrom <eric.engestrom@imgtec.com> - 2016-04-25 15:00 +0200
            Re: [PATCH 4/4] ARM: remove duplicate const qualifier Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-04-25 16:20 +0200
              Re: [PATCH 4/4] ARM: remove duplicate const qualifier Eric Engestrom <eric.engestrom@imgtec.com> - 2016-04-25 16:40 +0200
                Re: [PATCH 4/4] ARM: remove duplicate const qualifier khalasa@piap.pl (Krzysztof Hałasa) - 2016-04-26 12:20 +0200
                Re: [PATCH 4/4] ARM: remove duplicate const qualifier Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-04-27 22:10 +0200
      Re: [PATCH 4/4] ARM: remove duplicate const qualifier Sylvain Lemieux <slemieux.tyco@gmail.com> - 2016-04-25 13:00 +0200
  [PATCH 2/4] drivers: firmware: psci: remove duplicate const qualifier Eric Engestrom <eric.engestrom@imgtec.com> - 2016-04-25 11:50 +0200
    Re: [PATCH 2/4] drivers: firmware: psci: remove duplicate const  qualifier Jisheng Zhang <jszhang@marvell.com> - 2016-04-25 12:40 +0200
  [PATCH 3/4] dmaengine: pxa_dma: remove duplicate const qualifier Eric Engestrom <eric.engestrom@imgtec.com> - 2016-04-25 11:50 +0200
    Re: [PATCH 3/4] dmaengine: pxa_dma: remove duplicate const qualifier Robert Jarzmik <robert.jarzmik@free.fr> - 2016-04-25 21:20 +0200
    Re: [PATCH 3/4] dmaengine: pxa_dma: remove duplicate const qualifier Vinod Koul <vinod.koul@intel.com> - 2016-04-26 18:30 +0200
  Re: [PATCH 1/4] perf tools: remove duplicate const qualifier Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-04-25 23:20 +0200
  [tip:perf/core] perf tools: Remove duplicate const qualifier tip-bot for Eric Engestrom <tipbot@zytor.com> - 2016-04-27 17:40 +0200

csiph-web