Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1386394

Re: [PATCH 4/4] ARM: remove duplicate const qualifier

Show all headers | View raw

On Mon, Apr 25, 2016 at 01:38:18PM +0200, Arnd Bergmann wrote:
> Maybe say you you found it (llvm, sparse, coccinelle?), and why this
> is causing a problem for anyone. If it's just unnecessary but not
> harmful, I'd probably ignore the patch.

$ grep -rE '(^|\W)const(\s+\w+)+\s+const\s'

I just happened to notice some unnecessary const in our internal code,
so I grep'ed for it in a couple big OSS projects to see how common it
was. Since I found only a few, I decided to remove them, but like I said
it just gets ignored by all the compilers I know, so there's absolutely
no harm in leaving this dead code around.


> That's fine. Having multiple patches here is slightly better than just
> one, but I'd also be fine with just taking the large patch because it
> is an identical trivial change in multiple files.

So, do you want me to split them up? I'd prefer not having to (slightly
less work for me :P), but it doesn't really make much of a difference
either way.

Cheers

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/4] perf tools: remove duplicate const qualifier Eric Engestrom <eric.engestrom@imgtec.com> - 2016-04-25 11:50 +0200
  [PATCH 4/4] ARM: remove duplicate const qualifier Eric Engestrom <eric.engestrom@imgtec.com> - 2016-04-25 11:50 +0200
    Re: [PATCH 4/4] ARM: remove duplicate const qualifier Viresh Kumar <viresh.kumar@linaro.org> - 2016-04-25 12:00 +0200
    Re: [PATCH 4/4] ARM: remove duplicate const qualifier Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-04-25 12:00 +0200
      Re: [PATCH 4/4] ARM: remove duplicate const qualifier Eric Engestrom <eric.engestrom@imgtec.com> - 2016-04-25 12:40 +0200
        Re: [PATCH 4/4] ARM: remove duplicate const qualifier Arnd Bergmann <arnd@arndb.de> - 2016-04-25 13:50 +0200
          Re: [PATCH 4/4] ARM: remove duplicate const qualifier Eric Engestrom <eric.engestrom@imgtec.com> - 2016-04-25 15:00 +0200
            Re: [PATCH 4/4] ARM: remove duplicate const qualifier Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-04-25 16:20 +0200
              Re: [PATCH 4/4] ARM: remove duplicate const qualifier Eric Engestrom <eric.engestrom@imgtec.com> - 2016-04-25 16:40 +0200
                Re: [PATCH 4/4] ARM: remove duplicate const qualifier khalasa@piap.pl (Krzysztof Hałasa) - 2016-04-26 12:20 +0200
                Re: [PATCH 4/4] ARM: remove duplicate const qualifier Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-04-27 22:10 +0200
      Re: [PATCH 4/4] ARM: remove duplicate const qualifier Sylvain Lemieux <slemieux.tyco@gmail.com> - 2016-04-25 13:00 +0200
  [PATCH 2/4] drivers: firmware: psci: remove duplicate const qualifier Eric Engestrom <eric.engestrom@imgtec.com> - 2016-04-25 11:50 +0200
    Re: [PATCH 2/4] drivers: firmware: psci: remove duplicate const  qualifier Jisheng Zhang <jszhang@marvell.com> - 2016-04-25 12:40 +0200
  [PATCH 3/4] dmaengine: pxa_dma: remove duplicate const qualifier Eric Engestrom <eric.engestrom@imgtec.com> - 2016-04-25 11:50 +0200
    Re: [PATCH 3/4] dmaengine: pxa_dma: remove duplicate const qualifier Robert Jarzmik <robert.jarzmik@free.fr> - 2016-04-25 21:20 +0200
    Re: [PATCH 3/4] dmaengine: pxa_dma: remove duplicate const qualifier Vinod Koul <vinod.koul@intel.com> - 2016-04-26 18:30 +0200
  Re: [PATCH 1/4] perf tools: remove duplicate const qualifier Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-04-25 23:20 +0200
  [tip:perf/core] perf tools: Remove duplicate const qualifier tip-bot for Eric Engestrom <tipbot@zytor.com> - 2016-04-27 17:40 +0200

csiph-web