Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1384527
| From | Peter Zijlstra <peterz@infradead.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v1 2/5] perf/x86/intel/pt: IP filtering register/cpuid bits |
| Date | 2016-04-21 21:20 +0200 |
| Message-ID | <rqsiS-5YO-7@gated-at.bofh.it> (permalink) |
| References | <rqoRX-2Wv-3@gated-at.bofh.it> <rqoRY-2Wv-27@gated-at.bofh.it> <rqqTM-4ry-3@gated-at.bofh.it> <rqrZv-5rZ-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, Apr 21, 2016 at 08:55:38PM +0200, Thomas Gleixner wrote: > On Thu, 21 Apr 2016, Borislav Petkov wrote: > > > +#define MSR_IA32_RTIT_ADDR0_A 0x00000580 > > > +#define MSR_IA32_RTIT_ADDR0_B 0x00000581 > > > +#define MSR_IA32_RTIT_ADDR1_A 0x00000582 > > > +#define MSR_IA32_RTIT_ADDR1_B 0x00000583 > > > +#define MSR_IA32_RTIT_ADDR2_A 0x00000584 > > > +#define MSR_IA32_RTIT_ADDR2_B 0x00000585 > > > +#define MSR_IA32_RTIT_ADDR3_A 0x00000586 > > > +#define MSR_IA32_RTIT_ADDR3_B 0x00000587 > > > > So can we not turn msr-index.h a dumping ground for MSRs pls? > > > > If those are only PT-relevant, why not define them all in pt.h? > > I have to disagree here. The MSRs itself can really go into msr-index.h while > the bit definitions might go elsewhere. What's wrong with having all MSRs at a > central place? So I agree with Thomas; the risk of not doing this is that we'll introduce the same MSR again, in another file, under another name. That's confusion we can do without.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v1 2/5] perf/x86/intel/pt: IP filtering register/cpuid bits Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2016-04-21 17:40 +0200
Re: [PATCH v1 2/5] perf/x86/intel/pt: IP filtering register/cpuid bits Borislav Petkov <bp@alien8.de> - 2016-04-21 19:50 +0200
Re: [PATCH v1 2/5] perf/x86/intel/pt: IP filtering register/cpuid bits Thomas Gleixner <tglx@linutronix.de> - 2016-04-21 21:00 +0200
Re: [PATCH v1 2/5] perf/x86/intel/pt: IP filtering register/cpuid bits Peter Zijlstra <peterz@infradead.org> - 2016-04-21 21:20 +0200
Re: [PATCH v1 2/5] perf/x86/intel/pt: IP filtering register/cpuid bits Borislav Petkov <bp@alien8.de> - 2016-04-21 22:50 +0200
Re: [PATCH v1 2/5] perf/x86/intel/pt: IP filtering register/cpuid bits Borislav Petkov <bp@alien8.de> - 2016-04-21 22:40 +0200
Re: [PATCH v1 2/5] perf/x86/intel/pt: IP filtering register/cpuid bits Thomas Gleixner <tglx@linutronix.de> - 2016-04-22 10:10 +0200
Re: [PATCH v1 2/5] perf/x86/intel/pt: IP filtering register/cpuid bits Borislav Petkov <bp@alien8.de> - 2016-04-22 11:40 +0200
csiph-web