Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1384064

RE: [PATCHv2] wlcore: spi: add wl18xx support

Show all headers | View raw

> 
> > Thanks! Glad the illustration helped.
> > I will try it out again as if i recall cotrectly, i did try that l, and it didnt produce
> the correct waveform, but perhaps i didnt understand the usage of
> .cs_change correctly.
> > Will double check anyway.
> 
> It could also be a bug in your controller driver, it's common for them to not
> handle cs_change correctly (at least those that open code the message loop,
> obviously modern ones just factor this out into the core).

Tried looking into using cs_change and not sure I understand how it would do what I need.
According to, include/linux/spi/spi.h:

* All SPI transfers start with the relevant chipselect active.  Normally
* it stays selected until after the last transfer in a message.  Drivers
* can affect the chipselect signal using cs_change.
*
* (i) If the transfer isn't the last one in the message, this flag is
* used to make the chipselect briefly go inactive in the middle of the
* message.  Toggling chipselect in this way may be needed to terminate
* a chip command, letting a single spi_message perform all of group of
* chip transactions together.

Now, in my case I need the CS pin to go inactive and stay inactive during the transfer 
of the next byte for completing the SPI init correctly (sending the extra clock cycles while CS is inactive)
If I read the above correctly, CS will only briefly go inactive but will when the next byte 
is sent it will be active again.
What am I missing?

Best Regards,
Eyal

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCHv2] wlcore: spi: add wl18xx support Arnd Bergmann <arnd@arndb.de> - 2016-04-18 00:30 +0200
  RE: [PATCHv2] wlcore: spi: add wl18xx support "Reizer, Eyal" <eyalr@ti.com> - 2016-04-18 08:00 +0200
    Re: [PATCHv2] wlcore: spi: add wl18xx support Arnd Bergmann <arnd@arndb.de> - 2016-04-18 17:00 +0200
      RE: [PATCHv2] wlcore: spi: add wl18xx support "Reizer, Eyal" <eyalr@ti.com> - 2016-04-19 11:10 +0200
        Re: [PATCHv2] wlcore: spi: add wl18xx support Arnd Bergmann <arnd@arndb.de> - 2016-04-19 16:30 +0200
          RE: [PATCHv2] wlcore: spi: add wl18xx support "Reizer, Eyal" <eyalr@ti.com> - 2016-04-19 16:40 +0200
        Re: [PATCHv2] wlcore: spi: add wl18xx support Mark Brown <broonie@kernel.org> - 2016-04-19 19:20 +0200
          Re: [PATCHv2] wlcore: spi: add wl18xx support Mark Brown <broonie@kernel.org> - 2016-04-19 19:30 +0200
            Re: [PATCHv2] wlcore: spi: add wl18xx support Mark Brown <broonie@kernel.org> - 2016-04-19 20:00 +0200
              Re: [PATCHv2] wlcore: spi: add wl18xx support Mark Brown <broonie@kernel.org> - 2016-04-19 20:50 +0200
                RE: [PATCHv2] wlcore: spi: add wl18xx support "Reizer, Eyal" <eyalr@ti.com> - 2016-04-21 13:10 +0200
                Re: [PATCHv2] wlcore: spi: add wl18xx support Mark Brown <broonie@kernel.org> - 2016-04-21 13:20 +0200
    Re: [PATCHv2] wlcore: spi: add wl18xx support Mark Brown <broonie@kernel.org> - 2016-04-19 19:10 +0200

csiph-web