Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1380854

Re: [PATCHv2] wlcore: spi: add wl18xx support

Show all headers | View raw

On Sunday 10 April 2016 07:37:23 Reizer, Eyal wrote:
> Add support for using with both wl12xx and wl18xx.
> 
> - all wilink family needs special init command for entering wspi mode.
>   extra clock cycles should be sent after the spi init command while the
>   cs pin is high.
> - switch to controling the cs pin from the spi driver for achieveing the
>   above.
> - the selected cs gpio is read from the spi device-tree node using the
>   cs-gpios field and setup as a gpio.
> - See the example below for specifying the cs gpio using the cs-gpios entry
> &spi0   {
>         ...
>         cs-gpios = <&gpio0 5 0>;
>         ...
>         wlcore: wlcore@0 {
>                 compatible = "ti,wl1835";
>         ...
>         ...
>         };
> };
> 
> Signed-off-by: Eyal Reizer <eyalr@ti.com>

I don't think this can work in general: not all SPI hosts uses GPIOs
for controlling CS, so the logic can't work, and it's also a layering
violation for the driver to look at the parent.

I would suggest fixing this using a new API function from the SPI
core, if we don't already have a generic way to do it.

	Arnd

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCHv2] wlcore: spi: add wl18xx support Arnd Bergmann <arnd@arndb.de> - 2016-04-18 00:30 +0200
  RE: [PATCHv2] wlcore: spi: add wl18xx support "Reizer, Eyal" <eyalr@ti.com> - 2016-04-18 08:00 +0200
    Re: [PATCHv2] wlcore: spi: add wl18xx support Arnd Bergmann <arnd@arndb.de> - 2016-04-18 17:00 +0200
      RE: [PATCHv2] wlcore: spi: add wl18xx support "Reizer, Eyal" <eyalr@ti.com> - 2016-04-19 11:10 +0200
        Re: [PATCHv2] wlcore: spi: add wl18xx support Arnd Bergmann <arnd@arndb.de> - 2016-04-19 16:30 +0200
          RE: [PATCHv2] wlcore: spi: add wl18xx support "Reizer, Eyal" <eyalr@ti.com> - 2016-04-19 16:40 +0200
        Re: [PATCHv2] wlcore: spi: add wl18xx support Mark Brown <broonie@kernel.org> - 2016-04-19 19:20 +0200
          Re: [PATCHv2] wlcore: spi: add wl18xx support Mark Brown <broonie@kernel.org> - 2016-04-19 19:30 +0200
            Re: [PATCHv2] wlcore: spi: add wl18xx support Mark Brown <broonie@kernel.org> - 2016-04-19 20:00 +0200
              Re: [PATCHv2] wlcore: spi: add wl18xx support Mark Brown <broonie@kernel.org> - 2016-04-19 20:50 +0200
                RE: [PATCHv2] wlcore: spi: add wl18xx support "Reizer, Eyal" <eyalr@ti.com> - 2016-04-21 13:10 +0200
                Re: [PATCHv2] wlcore: spi: add wl18xx support Mark Brown <broonie@kernel.org> - 2016-04-21 13:20 +0200
    Re: [PATCHv2] wlcore: spi: add wl18xx support Mark Brown <broonie@kernel.org> - 2016-04-19 19:10 +0200

csiph-web