Re: [PATCH] xen/x86: actually allocate legacy interrupts on PV guests

From	Juergen Gross <jgross@suse.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] xen/x86: actually allocate legacy interrupts on PV guests
Date	2016-04-21 11:10 +0200
Message-ID	<rqiMy-6KC-1@gated-at.bofh.it> (permalink)
References	<rq0cV-8rY-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 20/04/16 15:15, Stefano Stabellini wrote:
> b4ff8389ed14 is incomplete: relies on nr_legacy_irqs() to get the number
> of legacy interrupts when actually nr_legacy_irqs() returns 0 after
> probe_8259A(). Use NR_IRQS_LEGACY instead.

Would you mind describing the resulting problem? With this commit
message I'm absolutely not capable to decide whether e.g. the other
use of nr_legacy_irqs() in pci_xen_initial_domain() is correct or
not.


Juergen

> 
> Signed-off-by: Stefano Stabellini <sstabellini@kernel.org>
> 
> diff --git a/arch/x86/pci/xen.c b/arch/x86/pci/xen.c
> index beac4df..349b8ce 100644
> --- a/arch/x86/pci/xen.c
> +++ b/arch/x86/pci/xen.c
> @@ -491,8 +491,11 @@ int __init pci_xen_initial_domain(void)
>  #endif
>  	__acpi_register_gsi = acpi_register_gsi_xen;
>  	__acpi_unregister_gsi = NULL;
> -	/* Pre-allocate legacy irqs */
> -	for (irq = 0; irq < nr_legacy_irqs(); irq++) {
> +	/*
> +	 * Pre-allocate the legacy IRQs.  Use NR_LEGACY_IRQS here
> +	 * because we don't have a PIC and thus nr_legacy_irqs() is zero.
> +	 */
> +	for (irq = 0; irq < NR_IRQS_LEGACY; irq++) {
>  		int trigger, polarity;
>  
>  		if (acpi_get_override_irq(irq, &trigger, &polarity) == -1)
>

Thread

[PATCH] xen/x86: actually allocate legacy interrupts on PV guests Stefano Stabellini <sstabellini@kernel.org> - 2016-04-20 15:20 +0200
  Re: [PATCH] xen/x86: actually allocate legacy interrupts on PV guests Juergen Gross <jgross@suse.com> - 2016-04-21 11:10 +0200
    Re: [PATCH] xen/x86: actually allocate legacy interrupts on PV  guests Stefano Stabellini <sstabellini@kernel.org> - 2016-04-21 11:40 +0200
      Re: [PATCH] xen/x86: actually allocate legacy interrupts on PV guests Juergen Gross <jgross@suse.com> - 2016-04-27 07:10 +0200
        Re: [Xen-devel] [PATCH] xen/x86: actually allocate legacy interrupts  on PV guests David Vrabel <david.vrabel@citrix.com> - 2016-04-27 11:40 +0200
          Re: [Xen-devel] [PATCH] xen/x86: actually allocate legacy interrupts  on PV guests Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2016-04-27 15:40 +0200
            Re: [Xen-devel] [PATCH] xen/x86: actually allocate legacy interrupts  on PV guests David Vrabel <david.vrabel@citrix.com> - 2016-04-27 15:50 +0200
              Re: [Xen-devel] [PATCH] xen/x86: actually allocate legacy interrupts  on PV guests Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2016-04-27 16:10 +0200
  Re: [Xen-devel] [PATCH] xen/x86: actually allocate legacy interrupts  on PV guests Olaf Hering <olaf@aepfle.de> - 2016-04-21 13:10 +0200

csiph-web