Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1382189
| Path | csiph.com!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Krzysztof Kozlowski <k.kozlowski@samsung.com> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] ARM: dts: exynos: Remove unsupported s2mps11 regulator bindings from Exynos5420 boards |
| Date | Tue, 19 Apr 2016 07:50:01 +0200 |
| Message-ID | <rpwHT-1JO-1@gated-at.bofh.it> (permalink) |
| References | <rpc6u-1G3-29@gated-at.bofh.it> <rpkGK-q2-13@gated-at.bofh.it> |
| X-Original-To | Javier Martinez Canillas <javier@osg.samsung.com>, Kukjin Kim <kgene@kernel.org>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org |
| X-Auditid | cbfec7f4-f796c6d000001486-8d-5715c62b1e92 |
| User-Agent | Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=windows-1252 |
| Content-Transfer-Encoding | 7bit |
| X-Brightmail-Tracker | H4sIAAAAAAAAA+NgFrrHLMWRmVeSWpSXmKPExsVy+t/xy7rax0TDDaY18VtsnLGe1WL+kXOs Fm/ermGyeP3C0KL/8Wtmi02Pr7FaXN41h81ixvl9TA4cHptWdbJ5bF5S77Gl/y67R9+WVYwe nzfJBbBGcdmkpOZklqUW6dslcGWsO/eEqeA4d8XbA7uZGxj3cXYxcnJICJhIHNn1jRnCFpO4 cG89WxcjF4eQwFJGieZ1N5ghnGeMEp83NYBVCQvkSjxYM50RJCEicJdRorVpBxNIQkggW+Ln sm52EJtZwEJi69bVYDabgLHE5uVL2EBsXgEtiZkrDoPZLAKqEjM3t7GA2KICERJP5p5khKgR lPgx+R5YnFNAX2LB3ZtAizmAZupJ3L+oBTFeXmLzmrfMExgFZiHpmIVQNQtJ1QJG5lWMoqml yQXFSem5hnrFibnFpXnpesn5uZsYIaH+ZQfj4mNWhxgFOBiVeHgDCkTDhVgTy4orcw8xSnAw K4nwZhwCCvGmJFZWpRblxxeV5qQWH2KU5mBREuedu+t9iJBAemJJanZqakFqEUyWiYNTqoHR Y4nULQYVPg8ZS22nCYLbWVnjN2/mNpngemvvyfPcUqt31a5kig9RffZwkdTrE5xTdOLlOk4a shnW/7/kfPa6R8pqn/uSO7eZq/9sk32TlsydtNRY4MFaroeB8S5uvfN+s/b8Lt4iFpTJ8u71 9c1G5469frs2zK7bUUJ2gs7xO1OnKu2qenxUiaU4I9FQi7moOBEAZddQfnECAAA= |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 35 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> |
| X-Original-Date | Tue, 19 Apr 2016 07:46:17 +0200 |
| X-Original-Message-ID | <5715C629.1030602@samsung.com> |
| X-Original-References | <1460965453-5337-1-git-send-email-k.kozlowski@samsung.com> <571510D5.3090406@osg.samsung.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1382189 |
Show key headers only | View raw
On 04/18/2016 06:52 PM, Javier Martinez Canillas wrote:
> Hello Krzysztof,
>
> On 04/18/2016 03:44 AM, Krzysztof Kozlowski wrote:
>> The bindings like s2mps11,buck6-ramp-enable or s2mps11,buck2-ramp-delay
>> where ignored. They were never parse by s2mps11 regulator driver. Also
>> the values used in these bindings were equal to default reset values of
>> S2MPS11 device. It is safe to remove them.
>>
>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>> ---
>
> The patch looks good to me.
>
> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
Thanks.
>
> On a related note, the s5m8767 regulator driver parses similar DT properties
> ("s5m8767,pmic-buck-ramp-delay", "s5m8767,pmic-buck2-ramp-enable", etc) that
> are not in Documentation/devicetree/bindings/regulator/samsung,s5m8767.txt.
>
> So those should either be added to the binding doc or removed from the driver
> if are not correct (I don't have documentation for the s5m8767 PMIC but the
> DT properties are not use by any DTS in mainline using the s5m8767 PMIC).
That's the grey area. :) I mean that instead of making these implemented
bindings an interface, they should rather be converted to standard
regulator bindings. However the device is quite old, not used on newer
boards, so there is no interest in improving this. In the same time
removal of this code is not strictly necessary. Its existence does not hurt.
Best regards,
Krzysztof
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] ARM: dts: exynos: Remove unsupported s2mps11 regulator bindings from Exynos5420 boards Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-18 09:50 +0200
Re: [PATCH] ARM: dts: exynos: Remove unsupported s2mps11 regulator bindings from Exynos5420 boards Javier Martinez Canillas <javier@osg.samsung.com> - 2016-04-18 19:00 +0200
Re: [PATCH] ARM: dts: exynos: Remove unsupported s2mps11 regulator bindings from Exynos5420 boards Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-19 07:50 +0200
Re: [PATCH] ARM: dts: exynos: Remove unsupported s2mps11 regulator bindings from Exynos5420 boards Javier Martinez Canillas <javier@osg.samsung.com> - 2016-04-19 22:20 +0200
csiph-web