Re: [PATCH] ARM: dts: exynos: Remove unsupported s2mps11 regulator bindings from Exynos5420 boards

From	Javier Martinez Canillas <javier@osg.samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ARM: dts: exynos: Remove unsupported s2mps11 regulator bindings from Exynos5420 boards
Date	2016-04-19 22:20 +0200
Message-ID	<rpKhP-41R-13@gated-at.bofh.it> (permalink)
References	<rpc6u-1G3-29@gated-at.bofh.it> <rpkGK-q2-13@gated-at.bofh.it> <rpwHT-1JO-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello Krzysztof,

On 04/19/2016 01:46 AM, Krzysztof Kozlowski wrote:
> On 04/18/2016 06:52 PM, Javier Martinez Canillas wrote:

[snip]

>>
>> On a related note, the s5m8767 regulator driver parses similar DT properties
>> ("s5m8767,pmic-buck-ramp-delay", "s5m8767,pmic-buck2-ramp-enable", etc) that
>> are not in Documentation/devicetree/bindings/regulator/samsung,s5m8767.txt.
>>
>> So those should either be added to the binding doc or removed from the driver
>> if are not correct (I don't have documentation for the s5m8767 PMIC but the
>> DT properties are not use by any DTS in mainline using the s5m8767 PMIC).
> 
> That's the grey area. :) I mean that instead of making these implemented
> bindings an interface, they should rather be converted to standard
> regulator bindings. However the device is quite old, not used on newer
> boards, so there is no interest in improving this. In the same time
> removal of this code is not strictly necessary. Its existence does not hurt.
>

Fair enough.
 
> Best regards,
> Krzysztof
> 

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ARM: dts: exynos: Remove unsupported s2mps11 regulator  bindings from Exynos5420 boards Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-18 09:50 +0200
  Re: [PATCH] ARM: dts: exynos: Remove unsupported s2mps11 regulator  bindings from Exynos5420 boards Javier Martinez Canillas <javier@osg.samsung.com> - 2016-04-18 19:00 +0200
    Re: [PATCH] ARM: dts: exynos: Remove unsupported s2mps11 regulator  bindings from Exynos5420 boards Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-19 07:50 +0200
      Re: [PATCH] ARM: dts: exynos: Remove unsupported s2mps11 regulator  bindings from Exynos5420 boards Javier Martinez Canillas <javier@osg.samsung.com> - 2016-04-19 22:20 +0200

csiph-web