Re: [PATCH] regulator: s2mps11: Remove unused set_voltage_time_sel

From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] regulator: s2mps11: Remove unused set_voltage_time_sel
Date	2016-04-18 13:10 +0200
Message-ID	<rpfe3-4x7-33@gated-at.bofh.it> (permalink)
References	<rpc6u-1G3-11@gated-at.bofh.it> <rpe8i-3k6-15@gated-at.bofh.it> <rpeL0-3XZ-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Mon, Apr 18, 2016 at 12:36:52PM +0200, Krzysztof Kozlowski wrote:
> On 04/18/2016 11:57 AM, Mark Brown wrote:

> > That's not the bug, the bug is that the driver is providing the
> > operation without providing a non-zero value for it.  The device tree
> > configuration is to override what the driver is doing.

> So your recommendation would be to set the ramp_delay value in
> regulator_desc structure?

Or at least fix the changelog to describe the problem more clearly.

> The problem is that value of 30 mv/us in datasheet looks untrustworthy
> (copied from other pages) and vendor kernel (which should be a
> reference) uses 12 mv/us. Anyway setting any value greater than 0 seems
> like better idea than just sticking to 0...

Yup.  Probably the more conservative value is going to be safer.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] regulator: s2mps11: Remove unused set_voltage_time_sel Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-18 09:50 +0200
  Re: [PATCH] regulator: s2mps11: Remove unused set_voltage_time_sel Mark Brown <broonie@kernel.org> - 2016-04-18 12:00 +0200
    Re: [PATCH] regulator: s2mps11: Remove unused set_voltage_time_sel Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-18 12:40 +0200
      Re: [PATCH] regulator: s2mps11: Remove unused set_voltage_time_sel Mark Brown <broonie@kernel.org> - 2016-04-18 13:10 +0200

csiph-web