Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1381442

Re: [PATCH] regulator: s2mps11: Remove unused set_voltage_time_sel

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Mon, Apr 18, 2016 at 09:42:58AM +0200, Krzysztof Kozlowski wrote:

> On S2MPS11 and S2MPS14 devices the default implementation of
> set_voltage_time_sel() for LDO regulators was not doing anything useful
> because users did not provide ramp delay in Device Tree so the
> set_voltage_time_sel() exited with status 0. This could be seen in
> dmesg, e.g. on Odroid XU4:

That's not the bug, the bug is that the driver is providing the
operation without providing a non-zero value for it.  The device tree
configuration is to override what the driver is doing.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] regulator: s2mps11: Remove unused set_voltage_time_sel Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-18 09:50 +0200
  Re: [PATCH] regulator: s2mps11: Remove unused set_voltage_time_sel Mark Brown <broonie@kernel.org> - 2016-04-18 12:00 +0200
    Re: [PATCH] regulator: s2mps11: Remove unused set_voltage_time_sel Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-18 12:40 +0200
      Re: [PATCH] regulator: s2mps11: Remove unused set_voltage_time_sel Mark Brown <broonie@kernel.org> - 2016-04-18 13:10 +0200

csiph-web