Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1381624
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/3] ASoC: jack: Add a jack detect callback via codec |
| Date | 2016-04-18 13:50 +0200 |
| Message-ID | <rpfQK-4Ut-17@gated-at.bofh.it> (permalink) |
| References | (2 earlier) <rpdFh-32l-15@gated-at.bofh.it> <rpdYB-3eO-5@gated-at.bofh.it> <rpe8h-3k6-3@gated-at.bofh.it> <rpehX-3HT-1@gated-at.bofh.it> <rpeBk-3TK-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
On Mon, Apr 18, 2016 at 06:20:00PM +0800, Xing Zheng wrote:
> On 2016年04月18日 18:03, Xing Zheng wrote:
> sound {
> ......
> simple-audio-card,dai-link@0 {
> format = "i2s";
> cpu {
> sound-dai = <&i2s0>;
> };
>
> codec {
> sound-dai = <&codec>;
>
> simple-audio-card,codec-jack =
> "JACK_HEADSET",
> "JACK_BTN_0",
> "JACK_BTN_1",
> "JACK_BTN_2",
> "JACK_BTN_3";
> };
> };
This seems like it's only half the job and worryingly close to Linux
internals. In particular the fact that the binding is specific to
simple-card and the fact that it's being placed on the CODEC (rather
than a separate object that the CODEC references) so that we can't
combine multiple devices are both a concern.
Dylan Reid did have an earlier go at defining a binding for this:
http://thread.gmane.org/gmane.linux.alsa.devel/138906
which went through a couple more iterations but the work on that seemed
to die off a bit.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/3] Add support simple-card parse jack detection via external codec Xing Zheng <zhengxing@rock-chips.com> - 2016-04-18 10:20 +0200
[PATCH 1/3] ASoC: jack: Add a jack detect callback via codec Xing Zheng <zhengxing@rock-chips.com> - 2016-04-18 10:20 +0200
Re: [PATCH 1/3] ASoC: jack: Add a jack detect callback via codec Mark Brown <broonie@kernel.org> - 2016-04-18 11:30 +0200
Re: [PATCH 1/3] ASoC: jack: Add a jack detect callback via codec Xing Zheng <zhengxing@rock-chips.com> - 2016-04-18 11:50 +0200
Re: [PATCH 1/3] ASoC: jack: Add a jack detect callback via codec Mark Brown <broonie@kernel.org> - 2016-04-18 12:00 +0200
Re: [PATCH 1/3] ASoC: jack: Add a jack detect callback via codec Xing Zheng <zhengxing@rock-chips.com> - 2016-04-18 12:10 +0200
Re: [PATCH 1/3] ASoC: jack: Add a jack detect callback via codec Xing Zheng <zhengxing@rock-chips.com> - 2016-04-18 12:30 +0200
Re: [PATCH 1/3] ASoC: jack: Add a jack detect callback via codec Mark Brown <broonie@kernel.org> - 2016-04-18 13:50 +0200
Re: [PATCH 1/3] ASoC: jack: Add a jack detect callback via codec Dylan Reid <dgreid@chromium.org> - 2016-04-18 18:50 +0200
[PATCH 2/3] ASoC: simple-card: Add support jack detection via codec Xing Zheng <zhengxing@rock-chips.com> - 2016-04-18 10:20 +0200
Re: [PATCH 2/3] ASoC: simple-card: Add support jack detection via codec Rob Herring <robh@kernel.org> - 2016-04-21 16:20 +0200
Re: [PATCH 2/3] ASoC: simple-card: Add support jack detection via codec Xing Zheng <zhengxing@rock-chips.com> - 2016-04-22 03:20 +0200
Re: [PATCH 2/3] ASoC: simple-card: Add support jack detection via codec Mark Brown <broonie@kernel.org> - 2016-04-22 11:30 +0200
Re: [alsa-devel] [PATCH 2/3] ASoC: simple-card: Add support jack detection via codec Jeremy McDermond <nh6z@nh6z.net> - 2016-04-22 18:50 +0200
Re: [alsa-devel] [PATCH 2/3] ASoC: simple-card: Add support jack detection via codec Jeremy McDermond <mcdermj@xenotropic.com> - 2016-04-22 18:50 +0200
Re: [alsa-devel] [PATCH 2/3] ASoC: simple-card: Add support jack detection via codec Mark Brown <broonie@kernel.org> - 2016-04-25 15:00 +0200
Re: [alsa-devel] [PATCH 2/3] ASoC: simple-card: Add support jack detection via codec Jeremy McDermond <nh6z@nh6z.net> - 2016-04-25 20:20 +0200
[PATCH 3/3] ASoC: da7219: Add detect_jack callback in the snd_soc_codec_driver Xing Zheng <zhengxing@rock-chips.com> - 2016-04-18 10:20 +0200
csiph-web