Re: [PATCH 1/3] ASoC: jack: Add a jack detect callback via codec

From	Xing Zheng <zhengxing@rock-chips.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] ASoC: jack: Add a jack detect callback via codec
Date	2016-04-18 12:10 +0200
Message-ID	<rpehX-3HT-1@gated-at.bofh.it> (permalink)
References	<rpczv-2aB-1@gated-at.bofh.it> <rpczw-2aB-7@gated-at.bofh.it> <rpdFh-32l-15@gated-at.bofh.it> <rpdYB-3eO-5@gated-at.bofh.it> <rpe8h-3k6-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

HI Mark,

On 2016年04月18日 17:53, Mark Brown wrote:
> On Mon, Apr 18, 2016 at 05:43:51PM +0800, Xing Zheng wrote:
>
>> The patch_1/3 add an export of a function that calls the _detect_jack_
>> function
>> when a codec supports jack detection and fill the _detect_jack_ function in
>> the
>> struct snd_soc_codec_driver.
> But why would anything ever call this function?  How is this supposed to
> be used?
In my opinion, this function is mainly to provide simple-card (patch_2/3).

This function will call and initialize jack detection if a codec 
supports it and fill the detect_jack function (patch_3/3 use it),
and, we don't need to create a customized machine driver to call the 
codec jack detection, the simple-card is able to
parse them.

Thanks.

-- 
- Xing Zheng

Thread

[PATCH 0/3] Add support simple-card parse jack detection via external codec Xing Zheng <zhengxing@rock-chips.com> - 2016-04-18 10:20 +0200
  [PATCH 1/3] ASoC: jack: Add a jack detect callback via codec Xing Zheng <zhengxing@rock-chips.com> - 2016-04-18 10:20 +0200
    Re: [PATCH 1/3] ASoC: jack: Add a jack detect callback via codec Mark Brown <broonie@kernel.org> - 2016-04-18 11:30 +0200
      Re: [PATCH 1/3] ASoC: jack: Add a jack detect callback via codec Xing Zheng <zhengxing@rock-chips.com> - 2016-04-18 11:50 +0200
        Re: [PATCH 1/3] ASoC: jack: Add a jack detect callback via codec Mark Brown <broonie@kernel.org> - 2016-04-18 12:00 +0200
          Re: [PATCH 1/3] ASoC: jack: Add a jack detect callback via codec Xing Zheng <zhengxing@rock-chips.com> - 2016-04-18 12:10 +0200
            Re: [PATCH 1/3] ASoC: jack: Add a jack detect callback via codec Xing Zheng <zhengxing@rock-chips.com> - 2016-04-18 12:30 +0200
              Re: [PATCH 1/3] ASoC: jack: Add a jack detect callback via codec Mark Brown <broonie@kernel.org> - 2016-04-18 13:50 +0200
                Re: [PATCH 1/3] ASoC: jack: Add a jack detect callback via codec Dylan Reid <dgreid@chromium.org> - 2016-04-18 18:50 +0200
  [PATCH 2/3] ASoC: simple-card: Add support jack detection via codec Xing Zheng <zhengxing@rock-chips.com> - 2016-04-18 10:20 +0200
    Re: [PATCH 2/3] ASoC: simple-card: Add support jack detection via  codec Rob Herring <robh@kernel.org> - 2016-04-21 16:20 +0200
      Re: [PATCH 2/3] ASoC: simple-card: Add support jack detection via  codec Xing Zheng <zhengxing@rock-chips.com> - 2016-04-22 03:20 +0200
        Re: [PATCH 2/3] ASoC: simple-card: Add support jack detection via  codec Mark Brown <broonie@kernel.org> - 2016-04-22 11:30 +0200
          Re: [alsa-devel] [PATCH 2/3] ASoC: simple-card: Add support jack detection via codec Jeremy McDermond <nh6z@nh6z.net> - 2016-04-22 18:50 +0200
          Re: [alsa-devel] [PATCH 2/3] ASoC: simple-card: Add support jack detection via codec Jeremy McDermond <mcdermj@xenotropic.com> - 2016-04-22 18:50 +0200
            Re: [alsa-devel] [PATCH 2/3] ASoC: simple-card: Add support jack  detection via codec Mark Brown <broonie@kernel.org> - 2016-04-25 15:00 +0200
              Re: [alsa-devel] [PATCH 2/3] ASoC: simple-card: Add support jack detection via codec Jeremy McDermond <nh6z@nh6z.net> - 2016-04-25 20:20 +0200
  [PATCH 3/3] ASoC: da7219: Add detect_jack callback in the snd_soc_codec_driver Xing Zheng <zhengxing@rock-chips.com> - 2016-04-18 10:20 +0200

csiph-web