Re: [PATCH 4/4] drivers: firmware: psci: use const and __initconst for psci_cpuidle_ops

From	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/4] drivers: firmware: psci: use const and __initconst for psci_cpuidle_ops
Date	2016-04-20 10:50 +0200
Message-ID	<rpVZF-4XX-19@gated-at.bofh.it> (permalink)
References	<rfvN7-5Sf-7@gated-at.bofh.it> <rfvN8-5Sf-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Mar 22, 2016 at 10:42:43PM +0800, Jisheng Zhang wrote:
> The psci_cpuidle_ops structures is not over-written, so add "const"
> qualifier and replace __initdata with __initconst.
> 
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
> ---
>  drivers/firmware/psci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>

> diff --git a/drivers/firmware/psci.c b/drivers/firmware/psci.c
> index 6d86881..7d52186 100644
> --- a/drivers/firmware/psci.c
> +++ b/drivers/firmware/psci.c
> @@ -355,7 +355,7 @@ int psci_cpu_suspend_enter(unsigned long index)
>  
>  /* ARM specific CPU idle operations */
>  #ifdef CONFIG_ARM
> -static struct cpuidle_ops psci_cpuidle_ops __initdata = {
> +static const struct cpuidle_ops psci_cpuidle_ops __initconst = {
>  	.suspend = psci_cpu_suspend_enter,
>  	.init = psci_dt_cpu_init_idle,
>  };
> -- 
> 2.8.0.rc3
>

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 4/4] drivers: firmware: psci: use const and __initconst  for psci_cpuidle_ops Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2016-04-20 10:50 +0200

csiph-web