Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1383110

Re: [PATCH] kernel/futex: handle the case where we got a "late" waiter

Show all headers | View raw

On Tue, 19 Apr 2016, Davidlohr Bueso wrote:
> On Fri, 15 Apr 2016, Sebastian Andrzej Siewior wrote:
> 
> > futex_unlock_pi() gets uval before taking the hb lock. Now imagine
> > someone in futex_lock_pi() took the lock. While futex_unlock_pi() waits
> > for the hb lock, the LOCK_PI sets FUTEX_WAITERS and drops the lock.
> > Now, futex_unlock_pi() figures out that there is waiter and invokes
> > wake_futex_pi() with the old uval which does not yet have FUTEX_WAITERS
> > set. This flaw lets cmpxchg_futex_value_locked() fail and return -EINVAL.
> 
> Hmm but if we're calling futex_unlock_pi() in the first place, doesn't that
> indicate that the uval already has FUTEX_WAITERS and therefore failed the
> TID->0 transition in userland? That or the thread is bogusly unlocking a
> lock that it doesn't own.

It can be called unconditionally w/o trying the TID->0 transition in user
space first and we should handle that case.
 
Thanks,

	tglx

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] kernel/futex: handle the case where we got a "late"  waiter Davidlohr Bueso <dave@stgolabs.net> - 2016-04-20 00:30 +0200
  Re: [PATCH] kernel/futex: handle the case where we got a "late"  waiter Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2016-04-20 09:10 +0200
  Re: [PATCH] kernel/futex: handle the case where we got a "late"  waiter Thomas Gleixner <tglx@linutronix.de> - 2016-04-20 09:40 +0200

csiph-web