[PATCH 2/2] i2c: s3c2410: Check clk_prepare_enable() return value

From	Javier Martinez Canillas <javier@osg.samsung.com>
Newsgroups	linux.kernel
Subject	[PATCH 2/2] i2c: s3c2410: Check clk_prepare_enable() return value
Date	2016-04-19 22:20 +0200
Message-ID	<rpKhP-41R-15@gated-at.bofh.it> (permalink)
References	<rpKhP-41R-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

The clk_prepare_enable() function can fail so check the return
value and propagate the error in case of a failure.

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>

---

 drivers/i2c/busses/i2c-s3c2410.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
index 4b873fe9a75b..cb40a3af46e7 100644
--- a/drivers/i2c/busses/i2c-s3c2410.c
+++ b/drivers/i2c/busses/i2c-s3c2410.c
@@ -1196,7 +1196,12 @@ static int s3c24xx_i2c_probe(struct platform_device *pdev)
 
 	/* initialise the i2c controller */
 
-	clk_prepare_enable(i2c->clk);
+	ret = clk_prepare_enable(i2c->clk);
+	if (ret) {
+		dev_err(&pdev->dev, "I2C clock enable failed (%d)\n", ret);
+		return ret;
+	}
+
 	ret = s3c24xx_i2c_init(i2c);
 	clk_disable(i2c->clk);
 	if (ret != 0) {
-- 
2.5.5

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] i2c: s3c2410: Check clk_prepare_enable() return value Javier Martinez Canillas <javier@osg.samsung.com> - 2016-04-19 22:20 +0200
  Re: [PATCH 2/2] i2c: s3c2410: Check clk_prepare_enable() return value Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-20 11:10 +0200

csiph-web