Re: [PATCH] thermal: tegra: mark PM functions __maybe_unused

From	Thierry Reding <thierry.reding@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] thermal: tegra: mark PM functions __maybe_unused
Date	2016-04-19 14:50 +0200
Message-ID	<rpDgm-6X3-17@gated-at.bofh.it> (permalink)
References	<roF0S-Ro-17@gated-at.bofh.it> <rpbDs-1sC-21@gated-at.bofh.it> <rptK1-80Y-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Tue, Apr 19, 2016 at 10:35:55AM +0800, Wei Ni wrote:
> 
> 
> On 2016年04月18日 15:15, Thierry Reding wrote:
> > * PGP Signed by an unknown key
> > 
> > On Sat, Apr 16, 2016 at 10:19:33PM +0200, Arnd Bergmann wrote:
> >> After the PM support has been added to this driver, we get
> >> a harmless warning when that support is disabled at compile
> >> time:
> >>
> >> drivers/thermal/tegra/soctherm.c:641:12: error: 'soctherm_resume' defined but not used [-Werror=unused-function]
> >>  static int soctherm_resume(struct device *dev)
> >>
> >> This marks the two PM functions as __maybe_unused to shut up
> >> the warning. This is preferred over adding an #ifdef around
> >> them, as it is harder to get wrong, and provides better
> >> compile-time coverage.
> >>
> >> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> >> Fixes: a134b4143b65 ("thermal: tegra: add PM support")
> >> ---
> >>  drivers/thermal/tegra/soctherm.c | 4 ++--
> >>  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > The need for this should go away when Jon's generic power domain series
> 
> Hi Thierry,
> Could you please show me the Jon's generic power domain series, so that I can
> verify it.

Here are the remaining patches from Jon's series:

	https://patchwork.ozlabs.org/patch/603285/
	https://patchwork.ozlabs.org/patch/603287/
	https://patchwork.ozlabs.org/patch/603284/

Thierry

Thread

[PATCH] thermal: tegra: mark PM functions __maybe_unused Arnd Bergmann <arnd@arndb.de> - 2016-04-16 22:30 +0200
  Re: [PATCH] thermal: tegra: mark PM functions __maybe_unused Thierry Reding <thierry.reding@gmail.com> - 2016-04-18 09:20 +0200
    Re: [PATCH] thermal: tegra: mark PM functions __maybe_unused Wei Ni <wni@nvidia.com> - 2016-04-19 04:40 +0200
      Re: [PATCH] thermal: tegra: mark PM functions __maybe_unused Thierry Reding <thierry.reding@gmail.com> - 2016-04-19 14:50 +0200
        Re: [PATCH] thermal: tegra: mark PM functions __maybe_unused Wei Ni <wni@nvidia.com> - 2016-04-20 08:50 +0200

csiph-web