Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1380615

[PATCH] thermal: tegra: mark PM functions __maybe_unused

Show all headers | View raw

After the PM support has been added to this driver, we get
a harmless warning when that support is disabled at compile
time:

drivers/thermal/tegra/soctherm.c:641:12: error: 'soctherm_resume' defined but not used [-Werror=unused-function]
 static int soctherm_resume(struct device *dev)

This marks the two PM functions as __maybe_unused to shut up
the warning. This is preferred over adding an #ifdef around
them, as it is harder to get wrong, and provides better
compile-time coverage.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: a134b4143b65 ("thermal: tegra: add PM support")
---
 drivers/thermal/tegra/soctherm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/thermal/tegra/soctherm.c b/drivers/thermal/tegra/soctherm.c
index 559c74279eb8..be829d6e131c 100644
--- a/drivers/thermal/tegra/soctherm.c
+++ b/drivers/thermal/tegra/soctherm.c
@@ -629,7 +629,7 @@ static int tegra_soctherm_remove(struct platform_device *pdev)
 	return 0;
 }
 
-static int soctherm_suspend(struct device *dev)
+static int __maybe_unused soctherm_suspend(struct device *dev)
 {
 	struct platform_device *pdev = to_platform_device(dev);
 
@@ -638,7 +638,7 @@ static int soctherm_suspend(struct device *dev)
 	return 0;
 }
 
-static int soctherm_resume(struct device *dev)
+static int __maybe_unused soctherm_resume(struct device *dev)
 {
 	struct platform_device *pdev = to_platform_device(dev);
 	struct tegra_soctherm *tegra = platform_get_drvdata(pdev);
-- 
2.7.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] thermal: tegra: mark PM functions __maybe_unused Arnd Bergmann <arnd@arndb.de> - 2016-04-16 22:30 +0200
  Re: [PATCH] thermal: tegra: mark PM functions __maybe_unused Thierry Reding <thierry.reding@gmail.com> - 2016-04-18 09:20 +0200
    Re: [PATCH] thermal: tegra: mark PM functions __maybe_unused Wei Ni <wni@nvidia.com> - 2016-04-19 04:40 +0200
      Re: [PATCH] thermal: tegra: mark PM functions __maybe_unused Thierry Reding <thierry.reding@gmail.com> - 2016-04-19 14:50 +0200
        Re: [PATCH] thermal: tegra: mark PM functions __maybe_unused Wei Ni <wni@nvidia.com> - 2016-04-20 08:50 +0200

csiph-web