[PATCH 10/15] __d_add(): don't drop/regain ->d_lock

From	Al Viro <viro@ZenIV.linux.org.uk>
Newsgroups	linux.kernel
Subject	[PATCH 10/15] __d_add(): don't drop/regain ->d_lock
Date	2016-04-16 03:00 +0200
Message-ID	<romKC-3oC-5@gated-at.bofh.it> (permalink)
References	<romKB-3oC-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Al Viro <viro@zeniv.linux.org.uk>

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
 fs/dcache.c | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/fs/dcache.c b/fs/dcache.c
index e9de4d9..33cad8a 100644
--- a/fs/dcache.c
+++ b/fs/dcache.c
@@ -2363,11 +2363,19 @@ EXPORT_SYMBOL(d_rehash);
 
 static inline void __d_add(struct dentry *dentry, struct inode *inode)
 {
+	spin_lock(&dentry->d_lock);
 	if (inode) {
-		__d_instantiate(dentry, inode);
+		unsigned add_flags = d_flags_for_inode(inode);
+		hlist_add_head(&dentry->d_u.d_alias, &inode->i_dentry);
+		raw_write_seqcount_begin(&dentry->d_seq);
+		__d_set_inode_and_type(dentry, inode, add_flags);
+		raw_write_seqcount_end(&dentry->d_seq);
+		__fsnotify_d_instantiate(dentry);
+	}
+	_d_rehash(dentry);
+	spin_unlock(&dentry->d_lock);
+	if (inode)
 		spin_unlock(&inode->i_lock);
-	}
-	d_rehash(dentry);
 }
 
 /**
-- 
2.8.0.rc3

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 10/15] __d_add(): don't drop/regain ->d_lock Al Viro <viro@ZenIV.linux.org.uk> - 2016-04-16 03:00 +0200
  Re: [PATCH 10/15] __d_add(): don't drop/regain ->d_lock Jeff Layton <jlayton@poochiereds.net> - 2016-04-24 20:10 +0200
    Re: [PATCH 10/15] __d_add(): don't drop/regain ->d_lock Al Viro <viro@ZenIV.linux.org.uk> - 2016-04-24 21:30 +0200

csiph-web