Re: [PATCH net-next] phy: make some bits preserved while setup forced mode

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH net-next] phy: make some bits preserved while setup forced mode
Date	2016-04-16 02:20 +0200
Message-ID	<rom7T-37C-3@gated-at.bofh.it> (permalink)
References	<rnrMn-116-37@gated-at.bofh.it> <rnKlY-6Jd-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Weidong Wang <wangweidong1@huawei.com>
Date: Thu, 14 Apr 2016 15:43:52 +0800

> When tested the PHY SGMII Loopback:
> 1.set the LOOPBACK bit,
> 2.set the autoneg to AUTONEG_DISABLE, it calls the
> genphy_setup_forced which will clear the bit.
> 
> The BMCR_LOOPBACK bit should be preserved.
> 
> As Florian pointed out that other bits should be preserved too.
> So I make the BMCR_ISOLATE and BMCR_PDOWN as well.
> 
> Signed-off-by: Weidong Wang <wangweidong1@huawei.com>

Applied, thank you.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RESEND PATCH net-next] phy: keep the BCMR_LOOPBACK bit while setup  forced mode Weidong Wang <wangweidong1@huawei.com> - 2016-04-13 14:10 +0200
  Re: [RESEND PATCH net-next] phy: keep the BCMR_LOOPBACK bit while  setup forced mode Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-04-13 16:30 +0200
    Re: [RESEND PATCH net-next] phy: keep the BCMR_LOOPBACK bit while  setup forced mode Weidong Wang <wangweidong1@huawei.com> - 2016-04-14 04:20 +0200
  Re: [RESEND PATCH net-next] phy: keep the BCMR_LOOPBACK bit while  setup forced mode Florian Fainelli <f.fainelli@gmail.com> - 2016-04-13 20:50 +0200
    Re: [RESEND PATCH net-next] phy: keep the BCMR_LOOPBACK bit while  setup forced mode Weidong Wang <wangweidong1@huawei.com> - 2016-04-14 05:50 +0200
  [PATCH net-next] phy: make some bits preserved while setup forced  mode Weidong Wang <wangweidong1@huawei.com> - 2016-04-14 10:00 +0200
    Re: [PATCH net-next] phy: make some bits preserved while setup  forced mode David Miller <davem@davemloft.net> - 2016-04-16 02:20 +0200

csiph-web