[RESEND PATCH net-next] phy: keep the BCMR_LOOPBACK bit while setup forced mode

From	Weidong Wang <wangweidong1@huawei.com>
Newsgroups	linux.kernel
Subject	[RESEND PATCH net-next] phy: keep the BCMR_LOOPBACK bit while setup forced mode
Date	2016-04-13 14:10 +0200
Message-ID	<rnrMn-116-37@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

When tested the PHY SGMII Loopback,:
1.set the LOOPBACK bit,
2.set the autoneg to AUTONEG_DISABLE, it calls the
genphy_setup_forced which will clear the bit.

So just keep the LOOPBACK bit while setup forced mode.

Signed-off-by: Weidong Wang <wangweidong1@huawei.com>
---
 drivers/net/phy/phy_device.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
index e551f3a..8da4b80 100644
--- a/drivers/net/phy/phy_device.c
+++ b/drivers/net/phy/phy_device.c
@@ -1124,7 +1124,9 @@ static int genphy_config_advert(struct phy_device *phydev)
 int genphy_setup_forced(struct phy_device *phydev)
 {
 	int ctl = 0;
+	int val = phy_read(phydev, MII_BMCR);

+	ctl |= val & BMCR_LOOPBACK;
 	phydev->pause = 0;
 	phydev->asym_pause = 0;

-- 2.7.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[RESEND PATCH net-next] phy: keep the BCMR_LOOPBACK bit while setup  forced mode Weidong Wang <wangweidong1@huawei.com> - 2016-04-13 14:10 +0200
  Re: [RESEND PATCH net-next] phy: keep the BCMR_LOOPBACK bit while  setup forced mode Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-04-13 16:30 +0200
    Re: [RESEND PATCH net-next] phy: keep the BCMR_LOOPBACK bit while  setup forced mode Weidong Wang <wangweidong1@huawei.com> - 2016-04-14 04:20 +0200
  Re: [RESEND PATCH net-next] phy: keep the BCMR_LOOPBACK bit while  setup forced mode Florian Fainelli <f.fainelli@gmail.com> - 2016-04-13 20:50 +0200
    Re: [RESEND PATCH net-next] phy: keep the BCMR_LOOPBACK bit while  setup forced mode Weidong Wang <wangweidong1@huawei.com> - 2016-04-14 05:50 +0200
  [PATCH net-next] phy: make some bits preserved while setup forced  mode Weidong Wang <wangweidong1@huawei.com> - 2016-04-14 10:00 +0200

csiph-web