Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller driver

From	Timur Tabi <timur@codeaurora.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller driver
Date	2016-04-15 19:10 +0200
Message-ID	<rofpN-6tr-53@gated-at.bofh.it> (permalink)
References	(2 earlier) <rnW3L-7VI-1@gated-at.bofh.it> <rnWZQ-h1-9@gated-at.bofh.it> <rnXCz-QG-13@gated-at.bofh.it> <rnZ1E-1K1-19@gated-at.bofh.it> <rof6p-63Q-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Bjorn Andersson wrote:
> For platform devices being populated via from DT you will pass:
> of_platform_bus_create()
>    of_platform_device_create_pdata()
>      of_dma_configure()
>
> Which calls of_dma_get_range() to acquire this information from the
> dma-ranges property and set up the dma ops and properties.

This seems excessive.  I have to create a platform bus just to configure 
the DMA mask?  Most drivers just call dma_set_mask and give it a number, 
and that's not device-tree specific.  I also need to come up with a way 
to get this to work on ACPI.

I just seems like a lot of work only because I need to determine at 
runtime what my DMA mask is.  I also don't see any drivers that call 
of_dma_configure().

-- 
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum, a Linux Foundation collaborative project.

Thread

Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller  driver Florian Fainelli <f.fainelli@gmail.com> - 2016-04-14 00:20 +0200
  Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller  driver Timur Tabi <timur@codeaurora.org> - 2016-04-14 22:30 +0200
    Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller  driver Florian Fainelli <f.fainelli@gmail.com> - 2016-04-14 23:30 +0200
      Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller  driver Vikram Sethi <vikrams@codeaurora.org> - 2016-04-15 00:10 +0200
        Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller  driver Timur Tabi <timur@codeaurora.org> - 2016-04-15 01:40 +0200
          Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller driver Rob Herring <robh+dt@kernel.org> - 2016-04-15 14:40 +0200
            Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller  driver Timur Tabi <timur@codeaurora.org> - 2016-04-15 17:50 +0200
              Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller driver Rob Herring <robh+dt@kernel.org> - 2016-04-15 18:00 +0200
                Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller  driver Timur Tabi <timur@codeaurora.org> - 2016-04-15 19:30 +0200
          Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller  driver Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-04-15 18:50 +0200
            Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller  driver Timur Tabi <timur@codeaurora.org> - 2016-04-15 19:10 +0200
              Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller  driver Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-04-15 19:40 +0200
                Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller  driver Timur Tabi <timur@codeaurora.org> - 2016-04-15 20:30 +0200
      Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller  driver Timur Tabi <timur@codeaurora.org> - 2016-04-21 20:10 +0200
        Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller  driver Timur Tabi <timur@codeaurora.org> - 2016-04-22 21:50 +0200
          Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller  driver Florian Fainelli <f.fainelli@gmail.com> - 2016-04-22 22:00 +0200
        Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller  driver Andrew Lunn <andrew@lunn.ch> - 2016-04-25 15:20 +0200

csiph-web