Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1380058

Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller driver

Show all headers | View raw

On Fri 15 Apr 10:00 PDT 2016, Timur Tabi wrote:

> Bjorn Andersson wrote:
> >For platform devices being populated via from DT you will pass:
> >of_platform_bus_create()
> >   of_platform_device_create_pdata()
> >     of_dma_configure()
> >
> >Which calls of_dma_get_range() to acquire this information from the
> >dma-ranges property and set up the dma ops and properties.
> 
> This seems excessive.  I have to create a platform bus just to configure the
> DMA mask?  Most drivers just call dma_set_mask and give it a number, and
> that's not device-tree specific.  I also need to come up with a way to get
> this to work on ACPI.
> 
> I just seems like a lot of work only because I need to determine at runtime
> what my DMA mask is.  I also don't see any drivers that call
> of_dma_configure().
> 

Your driver is a platform driver and it's being probed from DT. As such
all this is already taken care of for you, by the core.

The listing is for your reference to know why the dma-ranges property
would affect your device.

Regards,
Bjorn

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller  driver Florian Fainelli <f.fainelli@gmail.com> - 2016-04-14 00:20 +0200
  Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller  driver Timur Tabi <timur@codeaurora.org> - 2016-04-14 22:30 +0200
    Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller  driver Florian Fainelli <f.fainelli@gmail.com> - 2016-04-14 23:30 +0200
      Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller  driver Vikram Sethi <vikrams@codeaurora.org> - 2016-04-15 00:10 +0200
        Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller  driver Timur Tabi <timur@codeaurora.org> - 2016-04-15 01:40 +0200
          Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller driver Rob Herring <robh+dt@kernel.org> - 2016-04-15 14:40 +0200
            Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller  driver Timur Tabi <timur@codeaurora.org> - 2016-04-15 17:50 +0200
              Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller driver Rob Herring <robh+dt@kernel.org> - 2016-04-15 18:00 +0200
                Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller  driver Timur Tabi <timur@codeaurora.org> - 2016-04-15 19:30 +0200
          Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller  driver Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-04-15 18:50 +0200
            Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller  driver Timur Tabi <timur@codeaurora.org> - 2016-04-15 19:10 +0200
              Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller  driver Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-04-15 19:40 +0200
                Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller  driver Timur Tabi <timur@codeaurora.org> - 2016-04-15 20:30 +0200
      Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller  driver Timur Tabi <timur@codeaurora.org> - 2016-04-21 20:10 +0200
        Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller  driver Timur Tabi <timur@codeaurora.org> - 2016-04-22 21:50 +0200
          Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller  driver Florian Fainelli <f.fainelli@gmail.com> - 2016-04-22 22:00 +0200
        Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller  driver Andrew Lunn <andrew@lunn.ch> - 2016-04-25 15:20 +0200

csiph-web