Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1380018

Re: [PATCH 1/2 v2] device-tree: nexus7-flo: Remove power gpio key entry and use pmic8xxx-pwrkey

Show all headers | View raw

On Thu, Apr 14, 2016 at 4:07 PM, John Stultz <john.stultz@linaro.org> wrote:
> Since the pmic8xxx-pwrkey driver is already supported in the
> qcom-apq8064.dtsi, and the pmic8xxx-pwrkey supports logic to
> configure proper device shutdown when ps_hold goes low, it is
> better to use that driver then a generic gpio button.
>
> Thus this patch remove the gpio power key entry here, so we
> don't get double input events from having two drivers enabled.
>
> The one gotcha with the pmic8xxx-pwrkey is it has a fairly
> long debounce delay, which we shorten here to make the button
> behave as expected.
>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Arnd Bergmann <arnd.bergmann@linaro.org>
> Cc: Pawel Moll <pawel.moll@arm.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Ian Campbell <ijc+devicetree@hellion.org.uk>
> Cc: Kumar Gala <galak@codeaurora.org>
> Cc: Andy Gross <agross@codeaurora.org>
> Cc: Vinay Simha BN <simhavcs@gmail.com>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Stephen Boyd <stephen.boyd@linaro.org>
> Cc: linux-arm-msm@vger.kernel.org
> Cc: devicetree@vger.kernel.org
> Signed-off-by: John Stultz <john.stultz@linaro.org>
> ---
> v2:
>  - Add wakeup-source entry as suggested by
>    Sudeep Holla <sudeep.holla@arm.com>
>
>  arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts | 16 ++++++++++------
>  1 file changed, 10 insertions(+), 6 deletions(-)

Acked-by: Rob Herring <robh@kernel.org>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2 v2] device-tree: nexus7-flo: Remove power gpio key entry and use pmic8xxx-pwrkey John Stultz <john.stultz@linaro.org> - 2016-04-14 23:10 +0200
  Re: [PATCH 1/2 v2] device-tree: nexus7-flo: Remove power gpio key  entry and use pmic8xxx-pwrkey Rob Herring <robh+dt@kernel.org> - 2016-04-15 19:00 +0200
  Re: [PATCH 1/2 v2] device-tree: nexus7-flo: Remove power gpio key  entry and use pmic8xxx-pwrkey Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-04-15 19:30 +0200
    Re: [PATCH 1/2 v2] device-tree: nexus7-flo: Remove power gpio key  entry and use pmic8xxx-pwrkey Stephen Boyd <sboyd@codeaurora.org> - 2016-04-15 21:00 +0200
      Re: [PATCH 1/2 v2] device-tree: nexus7-flo: Remove power gpio key  entry and use pmic8xxx-pwrkey John Stultz <john.stultz@linaro.org> - 2016-04-16 00:00 +0200
      Re: [PATCH 1/2 v2] device-tree: nexus7-flo: Remove power gpio key  entry and use pmic8xxx-pwrkey Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-04-16 00:10 +0200
        Re: [PATCH 1/2 v2] device-tree: nexus7-flo: Remove power gpio key  entry and use pmic8xxx-pwrkey Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-04-17 14:30 +0200

csiph-web