Re: [PATCH 1/2 v2] device-tree: nexus7-flo: Remove power gpio key entry and use pmic8xxx-pwrkey

From	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2 v2] device-tree: nexus7-flo: Remove power gpio key entry and use pmic8xxx-pwrkey
Date	2016-04-17 14:30 +0200
Message-ID	<roTZT-49b-9@gated-at.bofh.it> (permalink)
References	<rnWGu-5f-9@gated-at.bofh.it> <rofJ7-6Cp-1@gated-at.bofh.it> <roh8e-7AR-13@gated-at.bofh.it> <rok67-1C3-33@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Apr 15, 2016 at 03:01:06PM -0700, Bjorn Andersson wrote:
> On Fri 15 Apr 11:59 PDT 2016, Stephen Boyd wrote:
> 
> [..]
> 
> > ----8<-----
> > From: Stephen Boyd <sboyd@codeaurora.org>
> > Subject: [PATCH] Input: pmic8xxx-pwrkey: Fix algorithm for converting trigger
> >  delay
> > 
> > The trigger delay algorithm that converts from microseconds to
> > the register value looks incorrect. According to most of the PMIC
> > documentation, the equation is
> > 
> > 	delay (Seconds) = (1 / 1024) * 2 ^ (x + 4)
> > 
> > except for one case where the documentation looks to have a
> > formatting issue and the equation looks like
> > 
> > 	delay (Seconds) = (1 / 1024) * 2 x + 4
> > 
> > Most likely this driver was written with the improper
> > documentation to begin with. According to the downstream sources
> > the valid delays are from 2 seconds to 1/64 second, and the
> > latter equation just doesn't make sense for that. Let's fix the
> > algorithm and the range check to match the documentation and the
> > downstream sources.
> > 
> > Reported-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> 
> Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>

Applied, thank you.

-- 
Dmitry

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/2 v2] device-tree: nexus7-flo: Remove power gpio key  entry and use pmic8xxx-pwrkey Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-04-15 19:30 +0200
  Re: [PATCH 1/2 v2] device-tree: nexus7-flo: Remove power gpio key  entry and use pmic8xxx-pwrkey Stephen Boyd <sboyd@codeaurora.org> - 2016-04-15 21:00 +0200
    Re: [PATCH 1/2 v2] device-tree: nexus7-flo: Remove power gpio key  entry and use pmic8xxx-pwrkey John Stultz <john.stultz@linaro.org> - 2016-04-16 00:00 +0200
    Re: [PATCH 1/2 v2] device-tree: nexus7-flo: Remove power gpio key  entry and use pmic8xxx-pwrkey Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-04-16 00:10 +0200
      Re: [PATCH 1/2 v2] device-tree: nexus7-flo: Remove power gpio key  entry and use pmic8xxx-pwrkey Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-04-17 14:30 +0200

csiph-web