Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1379920

Re: [BUG] cgroup/workques/fork: deadlock when moving cgroups

Show all headers | View raw

Hello,

On Fri, Apr 15, 2016 at 05:08:15PM +0200, Michal Hocko wrote:
> On Fri 15-04-16 10:38:15, Tejun Heo wrote:
> > Not necessarily.  The only thing necessary is flushing the work item
> > after releasing locks but before returning to user.
> > cpuset_post_attach_flush() does exactly the same thing.
> 
> Ahh, ok, didn't know that __cgroup_procs_write is doing something
> controller specific. Yes then we wouldn't need a generic callback if
> another code like above would be acceptable.

Yeah, I thought it'd be an one-off thing so didn't made it a generic
callback.  Making it a generic callback isn't a problem tho.

> > > really relies on the previous behavior I guess we can solve it with a
> > > post_move cgroup callback which would be called from a lockless context.
> > > 
> > > Anyway, before we go that way, can we at least consider the possibility
> > > of removing the kworker creation dependency on the global rwsem? AFAIU
> > > this locking was added because of the pid controller. Do we even care
> > > about something as volatile as kworkers in the pid controller?
> > 
> > It's not just pid controller and the global percpu locking has lower
> 
> where else would the locking matter? I have only checked the git history
> to build my picture so I might be missing something of course.

IIRC, there were followup patches which fixed and/or simplified
locking paths.  It's just generally a lot simpler to deal with.  The
downside obviously is that cgroup core operations can't depend on task
creation.  I didn't expect memcg to trigger it too tho.  I don't think
we wanna be doing heavy-lifting operations like node migration or page
relabeling while holding cgroup lock anyway, so would much prefer
making them async.

> > hotpath overhead.  We can try to exclude kworkers out of the locking
> > but that can get really nasty and there are already attempts to add
> > cgroup support to workqueue.  Will think more about it.  For now tho,
> > do you think making charge moving async would be difficult?
> 
> Well it certainly is not that trivial because it relies on being
> exclusive with global context. I will have to look closer of course but
> I cannot guarantee I will get to it before I get back from LSF. We can
> certainly discuss that at the conference. Johannes will be there as
> well.

I see.  For cpuset, it didn't really matter but what we can do is
creating a mechanism on cgroup core side which is called after a
migration operation is done after dropping the usual locks and
guarantees that no new migration will be started before the callbacks
finish.  If we have that, relocating charge moving outside the attach
path should be pretty trivial, right?

Thanks.

-- 
tejun

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[BUG] cgroup/workques/fork: deadlock when moving cgroups Petr Mladek <pmladek@suse.com> - 2016-04-13 11:50 +0200
  Re: [BUG] cgroup/workques/fork: deadlock when moving cgroups Tejun Heo <tj@kernel.org> - 2016-04-13 20:40 +0200
    Re: [BUG] cgroup/workques/fork: deadlock when moving cgroups Tejun Heo <tj@kernel.org> - 2016-04-13 21:00 +0200
    Re: [BUG] cgroup/workques/fork: deadlock when moving cgroups Michal Hocko <mhocko@kernel.org> - 2016-04-13 21:30 +0200
    Re: [BUG] cgroup/workques/fork: deadlock when moving cgroups Michal Hocko <mhocko@kernel.org> - 2016-04-13 21:30 +0200
      Re: [BUG] cgroup/workques/fork: deadlock when moving cgroups Michal Hocko <mhocko@kernel.org> - 2016-04-13 21:50 +0200
        Re: [BUG] cgroup/workques/fork: deadlock when moving cgroups Michal Hocko <mhocko@kernel.org> - 2016-04-14 09:10 +0200
          Re: [BUG] cgroup/workques/fork: deadlock when moving cgroups Tejun Heo <tj@kernel.org> - 2016-04-14 17:40 +0200
      Re: [BUG] cgroup/workques/fork: deadlock when moving cgroups Tejun Heo <tj@kernel.org> - 2016-04-13 21:50 +0200
      Re: [BUG] cgroup/workques/fork: deadlock when moving cgroups Johannes Weiner <hannes@cmpxchg.org> - 2016-04-14 20:00 +0200
        Re: [BUG] cgroup/workques/fork: deadlock when moving cgroups Michal Hocko <mhocko@kernel.org> - 2016-04-15 09:10 +0200
          Re: [BUG] cgroup/workques/fork: deadlock when moving cgroups Tejun Heo <tj@kernel.org> - 2016-04-15 16:40 +0200
            Re: [BUG] cgroup/workques/fork: deadlock when moving cgroups Michal Hocko <mhocko@kernel.org> - 2016-04-15 17:10 +0200
              Re: [BUG] cgroup/workques/fork: deadlock when moving cgroups Tejun Heo <tj@kernel.org> - 2016-04-15 17:30 +0200
                Re: [BUG] cgroup/workques/fork: deadlock when moving cgroups Michal Hocko <mhocko@kernel.org> - 2016-04-17 14:10 +0200
            Re: [BUG] cgroup/workques/fork: deadlock when moving cgroups Petr Mladek <pmladek@suse.com> - 2016-04-18 16:50 +0200
              Re: [BUG] cgroup/workques/fork: deadlock when moving cgroups Michal Hocko <mhocko@kernel.org> - 2016-04-19 16:10 +0200
                Re: [BUG] cgroup/workques/fork: deadlock when moving cgroups Petr Mladek <pmladek@suse.com> - 2016-04-19 17:40 +0200
        [PATCH for-4.6-fixes] memcg: remove lru_add_drain_all() invocation  from mem_cgroup_move_charge() Tejun Heo <tj@kernel.org> - 2016-04-15 21:30 +0200
          Re: [PATCH for-4.6-fixes] memcg: remove lru_add_drain_all()  invocation from mem_cgroup_move_charge() Michal Hocko <mhocko@kernel.org> - 2016-04-17 14:10 +0200
            Re: [PATCH for-4.6-fixes] memcg: remove lru_add_drain_all()  invocation from mem_cgroup_move_charge() Tejun Heo <tj@kernel.org> - 2016-04-20 23:30 +0200
              Re: [PATCH for-4.6-fixes] memcg: remove lru_add_drain_all()  invocation from mem_cgroup_move_charge() Michal Hocko <mhocko@kernel.org> - 2016-04-21 05:30 +0200
                Re: [PATCH for-4.6-fixes] memcg: remove lru_add_drain_all()  invocation from mem_cgroup_move_charge() Petr Mladek <pmladek@suse.com> - 2016-04-21 17:10 +0200
                Re: [PATCH for-4.6-fixes] memcg: remove lru_add_drain_all()  invocation from mem_cgroup_move_charge() Tejun Heo <tj@kernel.org> - 2016-04-21 18:00 +0200
            [PATCH 2/2] memcg: relocate charge moving from ->attach to  ->post_attach Tejun Heo <tj@kernel.org> - 2016-04-22 01:10 +0200
              Re: [PATCH 2/2] memcg: relocate charge moving from ->attach to  ->post_attach Petr Mladek <pmladek@suse.com> - 2016-04-22 16:00 +0200
              Re: [PATCH 2/2] memcg: relocate charge moving from ->attach to  ->post_attach Michal Hocko <mhocko@kernel.org> - 2016-04-25 10:30 +0200
                Re: [PATCH 2/2] memcg: relocate charge moving from ->attach to  ->post_attach Tejun Heo <tj@kernel.org> - 2016-04-25 21:50 +0200
              Re: [PATCH 2/2] memcg: relocate charge moving from ->attach to  ->post_attach Tejun Heo <tj@kernel.org> - 2016-04-25 21:50 +0200
            [PATCH 1/2] cgroup, cpuset: replace cpuset_post_attach_flush() with  cgroup_subsys->post_attach callback Tejun Heo <tj@kernel.org> - 2016-04-22 01:10 +0200
              Re: [PATCH 1/2] cgroup, cpuset: replace cpuset_post_attach_flush()  with cgroup_subsys->post_attach callback Tejun Heo <tj@kernel.org> - 2016-04-22 01:20 +0200
          [PATCH for-4.6-fixes] memcg: remove lru_add_drain_all() invocation  from mem_cgroup_move_charge() Tejun Heo <tj@kernel.org> - 2016-04-21 18:00 +0200

csiph-web