Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1379919

Re: [PATCH v2] pinctrl: pinctrl-single: Fix pcs_parse_bits_in_pinctrl_entry to use __ffs than ffs

Show all headers | View raw

* Linus Walleij <linus.walleij@linaro.org> [160415 02:29]:
> On Thu, Apr 14, 2016 at 6:59 AM, Keerthy <j-keerthy@ti.com> wrote:
> 
> > pcs_parse_bits_in_pinctrl_entry uses ffs which gives bit indices
> > ranging from 1 to MAX. This leads to a corner case where we try to request
> > the pin number = MAX and fails.
> >
> > bit_pos value is being calculted using ffs. pin_num_from_lsb uses
> > bit_pos value. pins array is populated with:
> >
> > pin + pin_num_from_lsb.
> >
> > The above is 1 more than usual bit indices as bit_pos uses ffs to compute
> > first set bit. Hence the last of the pins array is populated with the MAX
> > value and not MAX - 1 which causes error when we call pin_request.
> >
> > mask_pos is rightly calculated as ((pcs->fmask) << (bit_pos - 1))
> > Consequently val_pos and submask are correct.
> >
> > Hence use __ffs which gives (ffs(x) - 1) as the first bit set.
> >
> > fixes: 4e7e8017a8 ("pinctrl: pinctrl-single: enhance to configure multiple pins of different modules")
> > Signed-off-by: Keerthy <j-keerthy@ti.com>
> > ---
> >
> > Changes in v2:
> >
> >   * Changed pcs->fshift to use __ffs instead of ffs to be consistent.
> >
> > Boot tesed on da850-evm and checked the pinctrl sysfs nodes.
> 
> Patch applied for fixes with Tony's ACK.
> 
> Should it also be tagged for stable?

Probably a good idea, I can see somebody pulling hair out because
of this in various product trees.

Regards,

Tony

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2]  pinctrl: pinctrl-single: Fix pcs_parse_bits_in_pinctrl_entry to use __ffs than ffs Keerthy <j-keerthy@ti.com> - 2016-04-14 07:10 +0200
  Re: [PATCH v2]  pinctrl: pinctrl-single: Fix  pcs_parse_bits_in_pinctrl_entry to use __ffs than ffs Tony Lindgren <tony@atomide.com> - 2016-04-14 18:10 +0200
  Re: [PATCH v2] pinctrl: pinctrl-single: Fix pcs_parse_bits_in_pinctrl_entry  to use __ffs than ffs Linus Walleij <linus.walleij@linaro.org> - 2016-04-15 11:30 +0200
    Re: [PATCH v2] pinctrl: pinctrl-single: Fix  pcs_parse_bits_in_pinctrl_entry to use __ffs than ffs Tony Lindgren <tony@atomide.com> - 2016-04-15 17:30 +0200
      Re: [PATCH v2] pinctrl: pinctrl-single: Fix pcs_parse_bits_in_pinctrl_entry  to use __ffs than ffs Linus Walleij <linus.walleij@linaro.org> - 2016-04-23 11:50 +0200
        Re: [PATCH v2] pinctrl: pinctrl-single: Fix  pcs_parse_bits_in_pinctrl_entry to use __ffs than ffs Tony Lindgren <tony@atomide.com> - 2016-04-26 18:20 +0200

csiph-web