Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1380743

Re: [PATCH] ARM: dts: omap3-n900: Specify peripherals LDO regulators initial mode

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

On Sun, Apr 17, 2016 at 09:14:08AM +0300, Ivaylo Dimitrov wrote:
> On 17.04.2016 03:05, Sebastian Reichel wrote:
> >On Sat, Apr 16, 2016 at 09:37:23AM +0300, Ivaylo Dimitrov wrote:
> >>Without that, regulators are left in the mode last set by the bootloader or
> >>by the kernel the device was rebooted from. This leads to various problems
> >>like non-working peripherals.
> >>
> >>Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
> >>---
> >>  arch/arm/boot/dts/omap3-n900.dts | 9 +++++++++
> >>  1 file changed, 9 insertions(+)
> >>
> >>diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts
> >>index b3c26a9..1bb36e2 100644
> >>--- a/arch/arm/boot/dts/omap3-n900.dts
> >>+++ b/arch/arm/boot/dts/omap3-n900.dts
> >>@@ -329,6 +329,7 @@
> >>  	regulator-name = "V28";
> >>  	regulator-min-microvolt = <2800000>;
> >>  	regulator-max-microvolt = <2800000>;
> >>+	regulator-initial-mode = <0x0e>;
> >>  	regulator-always-on; /* due to battery cover sensor */
> >>  };
> >
> >I think this should either get an additional
> >comment like /* MODE_NORMAL */ or implemented
> 
> According to the TRM, this is 'ACTIVE state', but that does not fit in the
> regulator framework terminology.

No problem with using STATE_ACTIVE or any other fitting description. IMHO
that "active" is misleading for regulators without "always-on/boot-on" tag,
but that was TI's decision.

> >using a define and a TWL4030_REGULATOR_MODE_NORMAL
> >constant to keep the *.dts easily readable.
> 
> We already have RES_STATE_ACTIVE defined in linux/i2c/twl.h, is there a way
> to include that in a dts?

Not in its current state. During kernel build the C preprocessor is
applied on the *.dts files. So the header may only contain
preprocessor macros (e.g. #define). For that solution something like
~/src/linux/include/dt-bindings/regulator/maxim,max77802.h should
be created for the twl regulator.

-- Sebastian

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] ARM: dts: omap3-n900: Specify peripherals LDO regulators initial mode Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> - 2016-04-16 08:40 +0200
  Re: [PATCH] ARM: dts: omap3-n900: Specify peripherals LDO regulators  initial mode Sebastian Reichel <sre@kernel.org> - 2016-04-17 02:10 +0200
    Re: [PATCH] ARM: dts: omap3-n900: Specify peripherals LDO regulators  initial mode Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> - 2016-04-17 08:20 +0200
      Re: [PATCH] ARM: dts: omap3-n900: Specify peripherals LDO regulators  initial mode Sebastian Reichel <sre@kernel.org> - 2016-04-17 14:30 +0200
        [PATCH v1] ARM: dts: omap3-n900: Specify peripherals LDO regulators initial mode Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> - 2016-04-17 16:40 +0200
          Re: [PATCH v1] ARM: dts: omap3-n900: Specify peripherals LDO  regulators initial mode Sebastian Reichel <sre@kernel.org> - 2016-04-18 07:20 +0200
          Re: [PATCH v1] ARM: dts: omap3-n900: Specify peripherals LDO  regulators initial mode Javier Martinez Canillas <javier@dowhile0.org> - 2016-04-19 23:20 +0200
          Re: [PATCH v1] ARM: dts: omap3-n900: Specify peripherals LDO  regulators initial mode Pavel Machek <pavel@ucw.cz> - 2016-04-24 12:10 +0200
            Re: [PATCH v1] ARM: dts: omap3-n900: Specify peripherals LDO  regulators initial mode Tony Lindgren <tony@atomide.com> - 2016-04-26 19:20 +0200

csiph-web