[PATCH] irq_poll: Remove redundant barrier when using clear_bit_unlock()

From	Davidlohr Bueso <dave@stgolabs.net>
Newsgroups	linux.kernel
Subject	[PATCH] irq_poll: Remove redundant barrier when using clear_bit_unlock()
Date	2016-04-16 20:00 +0200
Message-ID	<roCFJ-7pv-17@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

... as the call obviously already implies unlock/RC semantics,
therefore lets get rid of the superfluous smp_mb calls.

Signed-off-by: Davidlohr Bueso <dbueso@suse.de>
---
 lib/irq_poll.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/lib/irq_poll.c b/lib/irq_poll.c
index 836f7db4e548..2a6ae2720ccb 100644
--- a/lib/irq_poll.c
+++ b/lib/irq_poll.c
@@ -50,7 +50,6 @@ EXPORT_SYMBOL(irq_poll_sched);
 static void __irq_poll_complete(struct irq_poll *iop)
 {
 	list_del(&iop->list);
-	smp_mb__before_atomic();
 	clear_bit_unlock(IRQ_POLL_F_SCHED, &iop->state);
 }
 
@@ -161,7 +160,6 @@ EXPORT_SYMBOL(irq_poll_disable);
 void irq_poll_enable(struct irq_poll *iop)
 {
 	BUG_ON(!test_bit(IRQ_POLL_F_SCHED, &iop->state));
-	smp_mb__before_atomic();
 	clear_bit_unlock(IRQ_POLL_F_SCHED, &iop->state);
 }
 EXPORT_SYMBOL(irq_poll_enable);
-- 
2.8.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] irq_poll: Remove redundant barrier when using clear_bit_unlock() Davidlohr Bueso <dave@stgolabs.net> - 2016-04-16 20:00 +0200
  Re: [PATCH] irq_poll: Remove redundant barrier when using  clear_bit_unlock() Davidlohr Bueso <dave@stgolabs.net> - 2016-04-20 06:30 +0200

csiph-web