Re: [PATCH] mmc: reduce nesting and join error strings into one line

From	Masahiro Yamada <yamada.masahiro@socionext.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mmc: reduce nesting and join error strings into one line
Date	2016-04-15 12:20 +0200
Message-ID	<ro910-1ni-13@gated-at.bofh.it> (permalink)
References	<r0eXT-3rF-9@gated-at.bofh.it> <ro7Vg-Er-1@gated-at.bofh.it> <ro8eC-Nk-11@gated-at.bofh.it> <ro8oi-S5-5@gated-at.bofh.it> <ro8oi-S5-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

2016-04-15 18:36 GMT+09:00 Ulf Hansson <ulf.hansson@linaro.org>:
> On 15 April 2016 at 11:30, Masahiro Yamada
> <yamada.masahiro@socionext.com> wrote:
>> 2016-04-15 18:26 GMT+09:00 Ulf Hansson <ulf.hansson@linaro.org>:
>>> On 15 April 2016 at 11:01, Masahiro Yamada
>>> <yamada.masahiro@socionext.com> wrote:
>>>> Hi Ulf,
>>>>
>>>> No interest in this clean-up?
>>>>
>>>
>>> Well, no.
>>>
>>> Don't get me wrong, I am interested in clean-ups, but this doesn't
>>> improve code quality that much.
>>>
>>
>> At least, current code splits the error message string into two lines.
>>
>>
>
> Yes, and that minor improvement also makes it more cumbersome to use
> "git blame" when trying to understand why something was changed.
>
> Hopes that clarifies how I think. It's balance. :-)

OK.  This balance slightly varies from maintainer to maintainer.

I am quite new to this sub-system, so I need to learn your criteria.

I spent some time to read the MMC core code before starting to write
my own MMC driver.
During diving into the code, I left some tiny patches,
which I think clean-ups(, but perhaps sound cumbersome for you).

So, please give me your 1 minute to learn how your bar's height.

For example, is the following above or below your bar?
https://github.com/masahir0y/linux-yamada/commit/fe4e4bc06

If welcome, I am happy to post it, of course.
but if not, please feel free to say so.

Thanks.

-- 
Best Regards
Masahiro Yamada

Thread

Re: [PATCH] mmc: reduce nesting and join error strings into one line Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-04-15 11:10 +0200
  Re: [PATCH] mmc: reduce nesting and join error strings into one line Ulf Hansson <ulf.hansson@linaro.org> - 2016-04-15 11:30 +0200
    Re: [PATCH] mmc: reduce nesting and join error strings into one line Ulf Hansson <ulf.hansson@linaro.org> - 2016-04-15 11:40 +0200
      Re: [PATCH] mmc: reduce nesting and join error strings into one line Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-04-15 12:20 +0200
        Re: [PATCH] mmc: reduce nesting and join error strings into one line Ulf Hansson <ulf.hansson@linaro.org> - 2016-04-15 13:10 +0200
    Re: [PATCH] mmc: reduce nesting and join error strings into one line Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-04-15 11:40 +0200

csiph-web