Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1379640

Re: [PATCH] mmc: reduce nesting and join error strings into one line

From Ulf Hansson <ulf.hansson@linaro.org>
Newsgroups linux.kernel
Subject Re: [PATCH] mmc: reduce nesting and join error strings into one line
Date 2016-04-15 11:40 +0200
Message-ID <ro8oi-S5-3@gated-at.bofh.it> (permalink)
References <r0eXT-3rF-9@gated-at.bofh.it> <ro7Vg-Er-1@gated-at.bofh.it> <ro8eC-Nk-11@gated-at.bofh.it> <ro8oi-S5-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On 15 April 2016 at 11:30, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
> 2016-04-15 18:26 GMT+09:00 Ulf Hansson <ulf.hansson@linaro.org>:
>> On 15 April 2016 at 11:01, Masahiro Yamada
>> <yamada.masahiro@socionext.com> wrote:
>>> Hi Ulf,
>>>
>>> No interest in this clean-up?
>>>
>>
>> Well, no.
>>
>> Don't get me wrong, I am interested in clean-ups, but this doesn't
>> improve code quality that much.
>>
>
> At least, current code splits the error message string into two lines.
>
>

Yes, and that minor improvement also makes it more cumbersome to use
"git blame" when trying to understand why something was changed.

Hopes that clarifies how I think. It's balance. :-)

Kind regards
Uffe

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] mmc: reduce nesting and join error strings into one line Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-04-15 11:10 +0200
  Re: [PATCH] mmc: reduce nesting and join error strings into one line Ulf Hansson <ulf.hansson@linaro.org> - 2016-04-15 11:30 +0200
    Re: [PATCH] mmc: reduce nesting and join error strings into one line Ulf Hansson <ulf.hansson@linaro.org> - 2016-04-15 11:40 +0200
      Re: [PATCH] mmc: reduce nesting and join error strings into one line Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-04-15 12:20 +0200
        Re: [PATCH] mmc: reduce nesting and join error strings into one line Ulf Hansson <ulf.hansson@linaro.org> - 2016-04-15 13:10 +0200
    Re: [PATCH] mmc: reduce nesting and join error strings into one line Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-04-15 11:40 +0200

csiph-web