Re: [PATCH 1/3] rxrpc: Don't permit use of connect() op and simplify sendmsg() op

From	David Howells <dhowells@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] rxrpc: Don't permit use of connect() op and simplify sendmsg() op
Date	2016-04-15 05:30 +0200
Message-ID	<ro2Ce-4Ew-7@gated-at.bofh.it> (permalink)
References	<ro0qK-2XM-3@gated-at.bofh.it> <rn870-W0-15@gated-at.bofh.it> <rn871-W0-41@gated-at.bofh.it> <ro0qK-2XM-3@gated-at.bofh.it>
Organization	Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903

Show all headers | View raw

David Miller <davem@davemloft.net> wrote:

> > Simplify the RxRPC user interface and remove the use of connect() to direct
> > client calls.  It is redundant given that sendmsg() can be given the target
> > address and calls to multiple targets are permitted from a client socket
> > and also from a service socket.
> 
> You can't just change completely the socket semantics for your
> protocol like this, every single userland application is going to
> break.
> 
> Sorry, there is no way I am applying changes like this.

Okay, fair enough.[*]

David

[*] I could point out that there is only one (under construction) userspace
application that uses this - and that doesn't use connect - but I can't quite
be 100% sure of that, so your point stands.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] RxRPC: 2nd rewrite part 2 David Howells <dhowells@redhat.com> - 2016-04-12 17:10 +0200
  [PATCH 2/3] rxrpc: The RXRPC_ACCEPT control message should not have  an address David Howells <dhowells@redhat.com> - 2016-04-12 17:10 +0200
  [PATCH 1/3] rxrpc: Don't permit use of connect() op and simplify  sendmsg() op David Howells <dhowells@redhat.com> - 2016-04-12 17:10 +0200
    Re: [PATCH 1/3] rxrpc: Don't permit use of connect() op and  simplify sendmsg() op David Miller <davem@davemloft.net> - 2016-04-15 03:10 +0200
      Re: [PATCH 1/3] rxrpc: Don't permit use of connect() op and simplify sendmsg() op David Howells <dhowells@redhat.com> - 2016-04-15 05:30 +0200

csiph-web