Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1377897

Re: [PATCH V2 3/5] gpio: of: Return error if gpio hog configuration failed

Show all headers | View raw

On Fri, Mar 11, 2016 at 2:43 PM, Laxman Dewangan <ldewangan@nvidia.com> wrote:

> If GPIO hog configuration failed while adding OF based
> gpiochip() then return the error instead of ignoring it.
>
> This helps of properly handling the gpio driver dependency.
>
> When adding the gpio hog nodes for NVIDIA's Tegra210 platforms,
> the gpio_hogd() fails with EPROBE_DEFER because pinctrl is not
> ready at this time and gpio_request() for Tegra GPIO driver
> returns error. The error was not causing the Tegra GPIO driver
> to fail as the error was getting ignored.
>
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> Cc: Benoit Parrot <bparrot@ti.com>
> Cc: Alexandre Courbot <acourbot@nvidia.com>
> Reviewed-by: Thierry Reding <treding@nvidia.com>

Rebased and applied this patch FWIW.
This is a fair and square bug fix so need to go in
no matter what happens with the hog patches.

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH V2 3/5] gpio: of: Return error if gpio hog configuration failed Linus Walleij <linus.walleij@linaro.org> - 2016-04-13 14:50 +0200
  Re: [PATCH V2 3/5] gpio: of: Return error if gpio hog configuration  failed Laxman Dewangan <ldewangan@nvidia.com> - 2016-04-13 15:10 +0200
    Re: [PATCH V2 3/5] gpio: of: Return error if gpio hog configuration failed Linus Walleij <linus.walleij@linaro.org> - 2016-04-14 15:00 +0200

csiph-web