Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1379384

RE: [PATCH net-next 2/2] intel: ixgbevf: Support Windows hosts (Hyper-V)

Show key headers only | View raw

> -----Original Message-----
> From: Alexander Duyck [mailto:alexander.duyck@gmail.com]
> Sent: Thursday, April 14, 2016 5:19 PM
> To: KY Srinivasan <kys@microsoft.com>
> Cc: Rustad, Mark D <mark.d.rustad@intel.com>; David Miller
> <davem@davemloft.net>; netdev <netdev@vger.kernel.org>; linux-
> kernel@vger.kernel.org; devel@linuxdriverproject.org; olaf@aepfle.de;
> apw@canonical.com; jasowang@redhat.com; eli@mellanox.com;
> jackm@mellanox.com; yevgenyp@mellanox.com; Ronciak, John
> <john.ronciak@intel.com>; intel-wired-lan@linuxonhyperv.com
> Subject: Re: [PATCH net-next 2/2] intel: ixgbevf: Support Windows hosts
> (Hyper-V)
> 
> On Thu, Apr 14, 2016 at 5:11 PM, KY Srinivasan <kys@microsoft.com> wrote:
> >
> >
> >> -----Original Message-----
> >> From: Rustad, Mark D [mailto:mark.d.rustad@intel.com]
> >> Sent: Thursday, April 14, 2016 5:07 PM
> >> To: KY Srinivasan <kys@microsoft.com>
> >> Cc: David Miller <davem@davemloft.net>; netdev
> >> <netdev@vger.kernel.org>; linux-kernel@vger.kernel.org;
> >> devel@linuxdriverproject.org; olaf@aepfle.de; apw@canonical.com;
> >> jasowang@redhat.com; eli@mellanox.com; jackm@mellanox.com;
> >> yevgenyp@mellanox.com; Ronciak, John <john.ronciak@intel.com>;
> intel-
> >> wired-lan@linuxonhyperv.com
> >> Subject: Re: [PATCH net-next 2/2] intel: ixgbevf: Support Windows hosts
> >> (Hyper-V)
> >>
> >> KY Srinivasan <kys@microsoft.com> wrote:
> >>
> >> >
> >> >
> >> >> -----Original Message-----
> >> >> From: Rustad, Mark D [mailto:mark.d.rustad@intel.com]
> >> >> Sent: Thursday, April 14, 2016 4:01 PM
> >> >> To: KY Srinivasan <kys@microsoft.com>
> >> >> Cc: David Miller <davem@davemloft.net>; netdev
> >> >> <netdev@vger.kernel.org>; linux-kernel@vger.kernel.org;
> >> >> devel@linuxdriverproject.org; olaf@aepfle.de; apw@canonical.com;
> >> >> jasowang@redhat.com; eli@mellanox.com; jackm@mellanox.com;
> >> >> yevgenyp@mellanox.com; Ronciak, John <john.ronciak@intel.com>;
> >> intel-
> >> >> wired-lan@linuxonhyperv.com
> >> >> Subject: Re: [PATCH net-next 2/2] intel: ixgbevf: Support Windows
> hosts
> >> >> (Hyper-V)
> >> >>
> >> >> Some comments below:
> >> >
> >> > Mark,
> >> >
> >> > Thank you for the comments. I will address them and repost the
> patches.
> >> >
> >> > Regards,
> >> >
> >> > K. Y
> >>
> >> Please look closely at Alex's comments. I think they are much more
> >> important.
> >
> > I am looking at Alex's comments as I am writing this.
> >
> 
> On additional thought that just occurred to me after looking over the
> other patches you submitted for the hv_netvsc is that you might just
> stub out the multicast, unicast, and vfta configuration calls for the
> hyperV interface since all that stuff should be handled by the other
> link in the bond anyway.  Then you should be able to mostly contain
> all the changes other than the device IDs to the vf.c file which is
> really how this kind of change should work anyway.

I will do that.
> 
> Also I was wondering.  Since HyperV is using a proprietary device ID
> anyway do you really need the calls like the one below?:
> +       if (x86_hyper == &x86_hyper_ms_hyperv) {
> 
> If we can just identify HyperV via the device Id then we could drop
> the x86 arch specific bits and instead just build for all cases.
Yes; I was planning to get rid of the x86 dependency. I will fix this.

K. Y
> 
> - Alex

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH net-next 2/2] intel: ixgbevf: Support Windows hosts (Hyper-V) "K. Y. Srinivasan" <kys@microsoft.com> - 2016-04-15 00:20 +0200
  Re: [PATCH net-next 2/2] intel: ixgbevf: Support Windows hosts  (Hyper-V) "Rustad, Mark D" <mark.d.rustad@intel.com> - 2016-04-15 01:10 +0200
    RE: [PATCH net-next 2/2] intel: ixgbevf: Support Windows hosts  (Hyper-V) KY Srinivasan <kys@microsoft.com> - 2016-04-15 02:10 +0200
      Re: [PATCH net-next 2/2] intel: ixgbevf: Support Windows hosts  (Hyper-V) "Rustad, Mark D" <mark.d.rustad@intel.com> - 2016-04-15 02:10 +0200
        RE: [PATCH net-next 2/2] intel: ixgbevf: Support Windows hosts  (Hyper-V) KY Srinivasan <kys@microsoft.com> - 2016-04-15 02:20 +0200
          Re: [PATCH net-next 2/2] intel: ixgbevf: Support Windows hosts (Hyper-V) Alexander Duyck <alexander.duyck@gmail.com> - 2016-04-15 02:20 +0200
            RE: [PATCH net-next 2/2] intel: ixgbevf: Support Windows hosts  (Hyper-V) KY Srinivasan <kys@microsoft.com> - 2016-04-15 02:30 +0200
          Re: [PATCH net-next 2/2] intel: ixgbevf: Support Windows hosts  (Hyper-V) "Rustad, Mark D" <mark.d.rustad@intel.com> - 2016-04-15 02:20 +0200
  Re: [PATCH net-next 2/2] intel: ixgbevf: Support Windows hosts (Hyper-V) Alexander Duyck <alexander.duyck@gmail.com> - 2016-04-15 01:20 +0200
    RE: [PATCH net-next 2/2] intel: ixgbevf: Support Windows hosts  (Hyper-V) KY Srinivasan <kys@microsoft.com> - 2016-04-15 04:50 +0200
      Re: [PATCH net-next 2/2] intel: ixgbevf: Support Windows hosts (Hyper-V) Alexander Duyck <alexander.duyck@gmail.com> - 2016-04-15 17:40 +0200
        RE: [PATCH net-next 2/2] intel: ixgbevf: Support Windows hosts  (Hyper-V) KY Srinivasan <kys@microsoft.com> - 2016-04-15 18:10 +0200

csiph-web