Re: [PATCH 2/2] asus-laptop: remove unused variable

From	Darren Hart <dvhart@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] asus-laptop: remove unused variable
Date	2016-04-15 02:40 +0200
Message-ID	<rnZXH-2t3-1@gated-at.bofh.it> (permalink)
References	<rloIV-Ti-11@gated-at.bofh.it> <rloIW-Ti-23@gated-at.bofh.it> <rmeet-7cM-3@gated-at.bofh.it> <rmje9-2gK-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Apr 10, 2016 at 11:48:52AM +0300, Giedrius Statkevičius wrote:
> On Sat, Apr 09, 2016 at 08:21:21PM -0700, Darren Hart wrote:
> > On Thu, Apr 07, 2016 at 11:20:01PM +0300, Giedrius Statkevičius wrote:
> > > `out' was assigned value but it was never used so remove it
> > > 
> > > Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@gmail.com>
> > > ---
> > >  drivers/platform/x86/asus-laptop.c | 3 ---
> > >  1 file changed, 3 deletions(-)
> > > 
> > > diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c
> > > index d86d42e..39ddcee 100644
> > > --- a/drivers/platform/x86/asus-laptop.c
> > > +++ b/drivers/platform/x86/asus-laptop.c
> > > @@ -946,11 +946,8 @@ static ssize_t sysfs_acpi_set(struct asus_laptop *asus,
> > >  			      const char *method)
> > >  {
> > >  	int rv, value;
> > > -	int out = 0;
> > >  
> > >  	rv = parse_arg(buf, count, &value);
> > > -	if (rv > 0)
> > > -		out = value ? 1 : 0;
> > >  
> > >  	if (write_acpi_int(asus->handle, method, value))
> > 
> > out is indeed unused, however the rv > 0 condition is relevant as <=0 will pass
> > value uninitialized to write_acpi_int.
> That's indeed a problem. Somehow I missed that :( Should I make a v2 to include
> another patch that checks for rv < 0 or send it as an independent one?
> 

Sorry, my response was not clear. Please resend both patches as a v2, with the
first unchanged, and this one updated to do the right thing. This just makes
managing the patches as series simpler.

Thank you,

-- 
Darren Hart
Intel Open Source Technology Center

Thread

[PATCH 1/2] asus-laptop: remove redundant initializers Giedrius Statkevičius   <giedrius.statkevicius@gmail.com> - 2016-04-07 22:30 +0200
  [PATCH 2/2] asus-laptop: remove unused variable Giedrius Statkevičius   <giedrius.statkevicius@gmail.com> - 2016-04-07 22:30 +0200
    Re: [PATCH 2/2] asus-laptop: remove unused variable Darren Hart <dvhart@infradead.org> - 2016-04-10 05:30 +0200
      Re: [PATCH 2/2] asus-laptop: remove unused variable Giedrius Statkevičius   <giedrius.statkevicius@gmail.com> - 2016-04-10 10:50 +0200
        Re: [PATCH 2/2] asus-laptop: remove unused variable Darren Hart <dvhart@infradead.org> - 2016-04-15 02:40 +0200
        Re: [PATCH 2/2] asus-laptop: remove unused variable Darren Hart <dvhart@infradead.org> - 2016-04-15 02:40 +0200

csiph-web