[PATCH net 2/3] net: dsa: mv88e6xxx: enable SA learning on DSA ports

From	Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Newsgroups	linux.kernel
Subject	[PATCH net 2/3] net: dsa: mv88e6xxx: enable SA learning on DSA ports
Date	2016-04-14 20:50 +0200
Message-ID	<rnUv0-6rs-15@gated-at.bofh.it> (permalink)
References	<rnUuZ-6rs-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

In multi-chip systems, DSA Tag ports must learn SA addresses in order to
correctly switch frames between interconnected chips.

This fixes cross-chip hardware bridging in a VLAN filtering aware
system, because a bridge group gets implemented as an hardware 802.1Q
VLAN and thus DSA and user ports share the same FDB.

Fixes: 4c7ea3c0791e ("net: dsa: mv88e6xxx: disable SA learning for DSA and CPU ports")
Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
---
 drivers/net/dsa/mv88e6xxx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/dsa/mv88e6xxx.c b/drivers/net/dsa/mv88e6xxx.c
index 7725e29..46c9b4c 100644
--- a/drivers/net/dsa/mv88e6xxx.c
+++ b/drivers/net/dsa/mv88e6xxx.c
@@ -2542,8 +2542,8 @@ static int mv88e6xxx_setup_port(struct dsa_switch *ds, int port)
 	 * the other bits clear.
 	 */
 	reg = 1 << port;
-	/* Disable learning for DSA and CPU ports */
-	if (dsa_is_cpu_port(ds, port) || dsa_is_dsa_port(ds, port))
+	/* Disable learning for CPU port */
+	if (dsa_is_cpu_port(ds, port))
 		reg = 0;
 
 	ret = _mv88e6xxx_reg_write(ds, REG_PORT(port), PORT_ASSOC_VECTOR, reg);
-- 
2.8.0

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net 0/3] net: dsa: mv88e6xxx: fix hardware cross-chip bridging Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-04-14 20:50 +0200
  [PATCH net 1/3] net: dsa: mv88e6xxx: unlock DSA and CPU ports Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-04-14 20:50 +0200
  [PATCH net 3/3] net: dsa: mv88e6xxx: share the same default FDB Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-04-14 20:50 +0200
  [PATCH net 2/3] net: dsa: mv88e6xxx: enable SA learning on DSA ports Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-04-14 20:50 +0200

csiph-web