Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1379211

[PATCH net 1/3] net: dsa: mv88e6xxx: unlock DSA and CPU ports

From Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Newsgroups linux.kernel
Subject [PATCH net 1/3] net: dsa: mv88e6xxx: unlock DSA and CPU ports
Date 2016-04-14 20:50 +0200
Message-ID <rnUuZ-6rs-11@gated-at.bofh.it> (permalink)
References <rnUuZ-6rs-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Locking a port generates an hardware interrupt when a new SA address is
received. This enables CPU directed learning, which is needed for 802.1X
MAC authentication.

To disable automatic learning on a port, the only configuration needed
is to set its Port Association Vector to all zero.

Clear PAV when SA learning should be disabled instead of locking a port.

Fixes: 4c7ea3c0791e ("net: dsa: mv88e6xxx: disable SA learning for DSA and CPU ports")
Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
---
 drivers/net/dsa/mv88e6xxx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/dsa/mv88e6xxx.c b/drivers/net/dsa/mv88e6xxx.c
index 9985a0c..7725e29 100644
--- a/drivers/net/dsa/mv88e6xxx.c
+++ b/drivers/net/dsa/mv88e6xxx.c
@@ -2544,7 +2544,7 @@ static int mv88e6xxx_setup_port(struct dsa_switch *ds, int port)
 	reg = 1 << port;
 	/* Disable learning for DSA and CPU ports */
 	if (dsa_is_cpu_port(ds, port) || dsa_is_dsa_port(ds, port))
-		reg = PORT_ASSOC_VECTOR_LOCKED_PORT;
+		reg = 0;
 
 	ret = _mv88e6xxx_reg_write(ds, REG_PORT(port), PORT_ASSOC_VECTOR, reg);
 	if (ret)
-- 
2.8.0

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH net 0/3] net: dsa: mv88e6xxx: fix hardware cross-chip bridging Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-04-14 20:50 +0200
  [PATCH net 1/3] net: dsa: mv88e6xxx: unlock DSA and CPU ports Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-04-14 20:50 +0200
  [PATCH net 3/3] net: dsa: mv88e6xxx: share the same default FDB Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-04-14 20:50 +0200
  [PATCH net 2/3] net: dsa: mv88e6xxx: enable SA learning on DSA ports Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-04-14 20:50 +0200

csiph-web