Re: [Question] refcount of DT node

From	Russell King - ARM Linux <linux@arm.linux.org.uk>
Newsgroups	linux.kernel
Subject	Re: [Question] refcount of DT node
Date	2016-04-14 20:40 +0200
Message-ID	<rnUlk-6mH-7@gated-at.bofh.it> (permalink)
References	<rnKch-6EY-5@gated-at.bofh.it> <rnL8m-7nM-15@gated-at.bofh.it> <rnMnM-4X-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Apr 14, 2016 at 10:59:57AM +0100, Mark Rutland wrote:
> On Thu, Apr 14, 2016 at 09:48:49AM +0100, Russell King - ARM Linux wrote:
> > On Thu, Apr 14, 2016 at 04:47:57PM +0900, Masahiro Yamada wrote:
> > > Hi experts.
> > > 
> > > My understanding of refcount of DT node is poor.
> > 
> > The message from DT people is... don't worry about DT node refcounting.
> > Do whatever you want with it, they don't care whether you have correct
> > refcounting or not.
> > 
> > The background behind that is that I've tried to fix the refcounting,
> > and even had the coccinelle people generate some stuff to work on this
> > issue, but DT people's attitude towards it is "don't bother".
> > 
> > So yes, people may get it wrong, but it seems it's something that DT
> > people want ignored.
> 
> I'm not sure that's quite fair; the last discussion I recall about this
> ended up concluding that we need a better API, rather than papering over
> problems.

Sorry, but I started out trying to get the of_node_put() stuff
correct, and sparked Julia into doing coccinelle patches, and I
was told by Rob that we shouldn't care about of_node_put() being
wrong, and the feeling is as I stated it: DT folk don't care
enough to fix the existing places, even though a great many can
be sorted via the coccinelle approach.

Their stance is not something I agree with - if we have something,
it should be correct, even if it's not what we would ultimately
desire, _or_ it should be removed.  This half-way house that we
have today is total madness to me.

-- 
RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

Thread

[Question] refcount of DT node Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-04-14 09:50 +0200
  Re: [Question] refcount of DT node Russell King - ARM Linux <linux@arm.linux.org.uk> - 2016-04-14 10:50 +0200
    Re: [Question] refcount of DT node Mark Rutland <mark.rutland@arm.com> - 2016-04-14 12:10 +0200
      Re: [Question] refcount of DT node Pantelis Antoniou <pantelis.antoniou@konsulko.com> - 2016-04-14 12:10 +0200
        Re: [Question] refcount of DT node Frank Rowand <frowand.list@gmail.com> - 2016-04-14 18:20 +0200
        Re: [Question] refcount of DT node Rob Herring <robh@kernel.org> - 2016-04-14 19:10 +0200
      Re: [Question] refcount of DT node Russell King - ARM Linux <linux@arm.linux.org.uk> - 2016-04-14 20:40 +0200
  Re: [Question] refcount of DT node Mark Rutland <mark.rutland@arm.com> - 2016-04-14 12:20 +0200
    Re: [Question] refcount of DT node Pantelis Antoniou <pantelis.antoniou@konsulko.com> - 2016-04-14 12:50 +0200

csiph-web