Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1378668

Re: [Question] refcount of DT node

From Pantelis Antoniou <pantelis.antoniou@konsulko.com>
Newsgroups linux.kernel
Subject Re: [Question] refcount of DT node
Date 2016-04-14 12:10 +0200
Message-ID <rnMnM-4X-7@gated-at.bofh.it> (permalink)
References <rnKch-6EY-5@gated-at.bofh.it> <rnL8m-7nM-15@gated-at.bofh.it> <rnMnM-4X-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hi Mark,

> On Apr 14, 2016, at 12:59 , Mark Rutland <mark.rutland@arm.com> wrote:
> 
> On Thu, Apr 14, 2016 at 09:48:49AM +0100, Russell King - ARM Linux wrote:
>> On Thu, Apr 14, 2016 at 04:47:57PM +0900, Masahiro Yamada wrote:
>>> Hi experts.
>>> 
>>> My understanding of refcount of DT node is poor.
>> 
>> The message from DT people is... don't worry about DT node refcounting.
>> Do whatever you want with it, they don't care whether you have correct
>> refcounting or not.
>> 
>> The background behind that is that I've tried to fix the refcounting,
>> and even had the coccinelle people generate some stuff to work on this
>> issue, but DT people's attitude towards it is "don't bother".
>> 
>> So yes, people may get it wrong, but it seems it's something that DT
>> people want ignored.
> 
> I'm not sure that's quite fair; the last discussion I recall about this
> ended up concluding that we need a better API, rather than papering over
> problems.
> 
> That said, there isn't much obvious progress on that front.
> 
> Frank, Pantelis, Rob, were there any conclusions on this from ELC, or is
> this something that needs someone to propose something?
> 

Frank mentioned that he wants a new API. I have some ideas about it too.

My take is that drivers should never do reference counting, we have to figure
out a way for DT access using copy semantics or locks.

References would still be required for core DT code, but that’s a sane subset.

> Mark.
> 
> [1] http://permalink.gmane.org/gmane.linux.drivers.devicetree/153777

Regards

— Pantelis

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[Question] refcount of DT node Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-04-14 09:50 +0200
  Re: [Question] refcount of DT node Russell King - ARM Linux <linux@arm.linux.org.uk> - 2016-04-14 10:50 +0200
    Re: [Question] refcount of DT node Mark Rutland <mark.rutland@arm.com> - 2016-04-14 12:10 +0200
      Re: [Question] refcount of DT node Pantelis Antoniou <pantelis.antoniou@konsulko.com> - 2016-04-14 12:10 +0200
        Re: [Question] refcount of DT node Frank Rowand <frowand.list@gmail.com> - 2016-04-14 18:20 +0200
        Re: [Question] refcount of DT node Rob Herring <robh@kernel.org> - 2016-04-14 19:10 +0200
      Re: [Question] refcount of DT node Russell King - ARM Linux <linux@arm.linux.org.uk> - 2016-04-14 20:40 +0200
  Re: [Question] refcount of DT node Mark Rutland <mark.rutland@arm.com> - 2016-04-14 12:20 +0200
    Re: [Question] refcount of DT node Pantelis Antoniou <pantelis.antoniou@konsulko.com> - 2016-04-14 12:50 +0200

csiph-web