Re: [PATCH 1/4] x86/events: down with test_thread_flag(TIF_IA32)

Path	csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	Andy Lutomirski <luto@amacapital.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/4] x86/events: down with test_thread_flag(TIF_IA32)
Date	Thu, 14 Apr 2016 20:40:02 +0200
Message-ID	<rnUlk-6mH-19@gated-at.bofh.it> (permalink)
References	<rnU1X-6dp-3@gated-at.bofh.it> <rnU1X-6dp-7@gated-at.bofh.it>
X-Original-To	Dmitry Safonov <dsafonov@virtuozzo.com>, Peter Zijlstra <peterz@infradead.org>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=amacapital-net.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=uAGCPaM67471LnhxQf7oSzP92MCcVnaBka4LzHcdl8Y=; b=AkKKdDwT4CVasVD5vET3fqXkpW0UUWQJIR39oaGMAHKxWpqzIvLcQ9Hd7ttTEMnM0h EhvOeZy2q4n1tD1rUeSjUBLc/RM9lU1qjMbZmN9OrUu0b/RXxsi/Nwxa8BeGViKAOGQz Vy8u4W3Kg+xW+6++xX2LtxwuHAeF/WB+iM8kxQS/iPK3xaw9sDzPj4T6SrnCvIHtXMAC Nzpne/bJs/7Xtq18E84/AmG4OZeEUuEJ909Ij5y8yoPuFfYYlUi4SuyYpm3W6amkepzb 5EjmE+A8bURhfHkB0pCFFPhcsSprdPlI+M1/wrFXQCH+uVhR5gtzgkH0bs3HqbxMtCYY LR6w==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=uAGCPaM67471LnhxQf7oSzP92MCcVnaBka4LzHcdl8Y=; b=CZ9cDg0HvqRqF70DOwTsfKGxY2kb6mO1hu6cAgvuzRQiuZA/jpuWPCTnT7lCPNaEE4 zU/uustgMtc4EDdh8TU5S/eUszLljRH06AwXesNSGwApR1r7dLYruZmVewsPqM5K2D+2 fj2BgT0qLhYmQxrsobuLbs/b0ftirchCTzsH/G8YgGIWpLcnrQsvta2tVSSUymCIEjL5 QEIwLdRN7+HxXl5t09G3R1Azz/jcgaAexVVcBaNCxhhExz7OWU18C3Vi9W7GFRUzvBox fN2oo6joz1hE+v0Ha3CbebVQzhvNI0MhfXMqqjuLyQxhf/0oIMImznfXdoYfmrvu9C8z XhwA==
X-Gm-Message-State	AOPr4FXTxUsmcykv1mDJRbBjSDCoLE6/Iyq6N25+WXHHjeUGPrCC8Q/H4S2SsfhizKcSV06EW00tdTBcp9cBdUNo
X-Received	by 10.182.103.231 with SMTP id fz7mr8538764obb.47.1460658747205; Thu, 14 Apr 2016 11:32:27 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	45
Organization	linux.* mail to news gateway
X-Original-Cc	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>, X86 ML <x86@kernel.org>, Robert Richter <rric@kernel.org>, oprofile-list@lists.sf.net, Dmitry Safonov <0x7f454c46@gmail.com>
X-Original-Date	Thu, 14 Apr 2016 11:32:07 -0700
X-Original-Message-ID	<CALCETrUJDdrH_brFuMGxEKcDUZbmxSevRjHNSCg-R_9vZ47kVg@mail.gmail.com>
X-Original-References	<1460657414-12530-1-git-send-email-dsafonov@virtuozzo.com> <1460657414-12530-2-git-send-email-dsafonov@virtuozzo.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1379206

Show key headers only | View raw

On Thu, Apr 14, 2016 at 11:10 AM, Dmitry Safonov <dsafonov@virtuozzo.com> wrote:
> We can use user_64bit_mode(regs) here instead of thread flag
> because we have full register frame.
>
> Signed-off-by: Dmitry Safonov <dsafonov@virtuozzo.com>
> ---
>  arch/x86/events/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/events/core.c b/arch/x86/events/core.c
> index 041e442a3e28..91d101a9a6e9 100644
> --- a/arch/x86/events/core.c
> +++ b/arch/x86/events/core.c
> @@ -2269,7 +2269,7 @@ perf_callchain_user32(struct pt_regs *regs, struct perf_callchain_entry *entry)
>         struct stack_frame_ia32 frame;
>         const void __user *fp;
>
> -       if (!test_thread_flag(TIF_IA32))
> +       if (user_64bit_mode(regs))
>                 return 0;

Peter, I got lost in the code that calls this.  Are regs coming from
the overflow interrupt's regs, current_pt_regs(), or
perf_get_regs_user?

If it's the perf_get_regs_user, then this should be okay, but passing
in the ABI field directly would be even nicer.  If they're coming from
the overflow interrupt's regs or current_pt_regs(), could we change
that?

It might also be nice to make sure that we call perf_get_regs_user
exactly once per overflow interrupt -- i.e. we could push it into the
main code rather than the regs sampling code.

>
>         cs_base = get_segment_base(regs->cs);
> --
> 2.8.0
>

-- 
Andy Lutomirski
AMA Capital Management, LLC

Thread

[PATCH 0/4] drop test_thread_flag checks Dmitry Safonov <dsafonov@virtuozzo.com> - 2016-04-14 20:20 +0200
  [PATCH 1/4] x86/events: down with test_thread_flag(TIF_IA32) Dmitry Safonov <dsafonov@virtuozzo.com> - 2016-04-14 20:20 +0200
    Re: [PATCH 1/4] x86/events: down with test_thread_flag(TIF_IA32) Andy Lutomirski <luto@amacapital.net> - 2016-04-14 20:40 +0200
  [PATCH 2/4] x86/intel: down with test_thread_flag(TIF_IA32) Dmitry Safonov <dsafonov@virtuozzo.com> - 2016-04-14 20:20 +0200

csiph-web