Re: [PATCH v5 30/46] regulator: pwm: retrieve correct voltage

From	Boris Brezillon <boris.brezillon@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 30/46] regulator: pwm: retrieve correct voltage
Date	2016-04-12 10:40 +0200
Message-ID	<rn21B-45R-19@gated-at.bofh.it> (permalink)
References	<riuBc-28V-5@gated-at.bofh.it> <riuBd-28V-39@gated-at.bofh.it> <rivQC-2TZ-9@gated-at.bofh.it> <rlq82-1KE-7@gated-at.bofh.it> <rmYr0-1aa-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Mark,

On Tue, 12 Apr 2016 05:42:03 +0100
Mark Brown <broonie@kernel.org> wrote:

> On Thu, Apr 07, 2016 at 11:54:31PM +0200, Boris Brezillon wrote:
> 
> > Is there any reason for calling set_machine_constraints() after
> > device_register() in regulator_register()?
> 
> I'm not sure there's a strong one, we don't really use the class device
> for anything, but without doing a full audit I couldn't guarantee that.

At first glance I don't see any problem (even the rdev_err/info/...()
functions do not use dev_err/info/...()). The patch will be part of v6
(unless you want me to send it independently).

Thanks,

Boris

-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Thread

Re: [PATCH v5 30/46] regulator: pwm: retrieve correct voltage Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-04-08 00:00 +0200
  Re: [PATCH v5 30/46] regulator: pwm: retrieve correct voltage Mark Brown <broonie@kernel.org> - 2016-04-12 06:50 +0200
    Re: [PATCH v5 30/46] regulator: pwm: retrieve correct voltage Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-04-12 10:40 +0200
      Re: [PATCH v5 30/46] regulator: pwm: retrieve correct voltage Mark Brown <broonie@kernel.org> - 2016-04-12 12:20 +0200
        Re: [PATCH v5 30/46] regulator: pwm: retrieve correct voltage Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-04-12 12:40 +0200

csiph-web