Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1374824
| Path | csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Pavel Machek <pavel@ucw.cz> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] fujitsu-laptop: Support radio LED |
| Date | Sun, 10 Apr 2016 20:30:02 +0200 |
| Message-ID | <rmshs-In-11@gated-at.bofh.it> (permalink) |
| References | <rdhOi-8i5-17@gated-at.bofh.it> |
| X-Original-To | Michał Kępień <kernel@kempniu.pl> |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=us-ascii |
| Content-Disposition | inline |
| User-Agent | Mutt/1.5.21 (2010-09-15) |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 30 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Jonathan Woithe <jwoithe@just42.net>, Darren Hart <dvhart@infradead.org>, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org |
| X-Original-Date | Tue, 22 Mar 2016 12:27:38 +0100 |
| X-Original-Message-ID | <20160322112738.GA26924@xo-6d-61-c0.localdomain> |
| X-Original-References | <1458127687-25366-1-git-send-email-kernel@kempniu.pl> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1374824 |
Show key headers only | View raw
Hi!
> Sadly, this implementation is unsuitable for use with "heavy" LED
> triggers, like phy0rx. Once blinking frequency achieves a certain
> level, the system hangs. I'm not sure how much of an issue this is as
> I'm pretty sure other LEDs registered by fujitsu-laptop would also cause
> a hang when assigned to a similar trigger as they are also controlled
> using ACPI.
Something to do with triggers working in interrupt context?
Cc led people?
> +
> +static enum led_brightness radio_led_get(struct led_classdev *cdev);
> +static void radio_led_set(struct led_classdev *cdev,
> + enum led_brightness brightness);
> +
> +static struct led_classdev radio_led = {
> + .name = "fujitsu::radio_led",
> + .brightness_get = radio_led_get,
> + .brightness_set = radio_led_set
> +};
Is the naming consistent with other drivers?
Should there be default trigger so that it works out of the box?
Best regards,
Pavel
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
Re: [PATCH] fujitsu-laptop: Support radio LED Pavel Machek <pavel@ucw.cz> - 2016-04-10 20:30 +0200
Re: [PATCH] fujitsu-laptop: Support radio LED Michał Kępień <kernel@kempniu.pl> - 2016-04-12 14:30 +0200
Re: [PATCH] fujitsu-laptop: Support radio LED Pavel Machek <pavel@ucw.cz> - 2016-04-14 14:50 +0200
csiph-web