Re: dm: ioctl: use kvfree

From	Rasmus Villemoes <linux@rasmusvillemoes.dk>
Newsgroups	linux.kernel
Subject	Re: dm: ioctl: use kvfree
Date	2016-04-11 22:00 +0200
Message-ID	<rmQa6-2Qx-17@gated-at.bofh.it> (permalink)
References	<rmLN8-7Xx-9@gated-at.bofh.it> <rmLN8-7Xx-7@gated-at.bofh.it> <rmMJb-gC-9@gated-at.bofh.it>
Organization	D03

Show all headers | View raw

On Mon, Apr 11 2016, Sudip Mukherjee <sudipm.mukherjee@gmail.com> wrote:

> On Monday 11 April 2016 08:47 PM, Mike Snitzer wrote:
>> On Mon, Apr 11 2016 at 11:14am -0400,
>> Sudip Mukherjee <sudipm.mukherjee@gmail.com> wrote:
>>
>>> We can use kvfree() instead of calling kfree() and vfree() based on
>>> if-else and param_flags. kvfree() will check the type of address and
>>> will call the respective function to free it.
>>> Additionally we can also remove the use of DM_PARAMS_KMALLOC and
>>> DM_PARAMS_VMALLOC.
>>>
>>> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
>>
>> Have you actually tested htis?  Last time I looked to do this it exposed
>> crashes.  I don't have time to dig into this again right now but this is
>> _not_ as simple as this patch implies.
>>
>
> No, it was just build tested. Is it possible to test it in qemu or kvm?
>

No need to test it, just read copy_params() and its caller,
ctl_ioctl(). The latter passes a stack buffer as param_kernel, and
copy_params() does

        if (ioctl_flags & IOCTL_FLAGS_NO_PARAMS) {
                dmi = param_kernel;

with dmi later returned via *param. So it is entirely possible that
free_params ends up calling neither kfree or vfree, since there's
nothing to free.

Rasmus

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: dm: ioctl: use kvfree Mike Snitzer <snitzer@redhat.com> - 2016-04-11 17:20 +0200
  Re: dm: ioctl: use kvfree Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-04-11 18:20 +0200
    Re: dm: ioctl: use kvfree Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2016-04-11 22:00 +0200

csiph-web