Re: dm: ioctl: use kvfree

From	Mike Snitzer <snitzer@redhat.com>
Newsgroups	linux.kernel
Subject	Re: dm: ioctl: use kvfree
Date	2016-04-11 17:20 +0200
Message-ID	<rmLN8-7Xx-7@gated-at.bofh.it> (permalink)
References	<rmLN8-7Xx-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Apr 11 2016 at 11:14am -0400,
Sudip Mukherjee <sudipm.mukherjee@gmail.com> wrote:

> We can use kvfree() instead of calling kfree() and vfree() based on
> if-else and param_flags. kvfree() will check the type of address and
> will call the respective function to free it.
> Additionally we can also remove the use of DM_PARAMS_KMALLOC and
> DM_PARAMS_VMALLOC.
> 
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>

Have you actually tested htis?  Last time I looked to do this it exposed
crashes.  I don't have time to dig into this again right now but this is
_not_ as simple as this patch implies.

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: dm: ioctl: use kvfree Mike Snitzer <snitzer@redhat.com> - 2016-04-11 17:20 +0200
  Re: dm: ioctl: use kvfree Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-04-11 18:20 +0200
    Re: dm: ioctl: use kvfree Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2016-04-11 22:00 +0200

csiph-web