Re: [PATCH v8 3/3] irqchip: add nps Internal and external irqchips

From	Marc Zyngier <marc.zyngier@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v8 3/3] irqchip: add nps Internal and external irqchips
Date	2016-04-11 16:50 +0200
Message-ID	<rmLk6-7vl-15@gated-at.bofh.it> (permalink)
References	(3 earlier) <rmKR5-7gk-37@gated-at.bofh.it> <rmKR5-7gk-39@gated-at.bofh.it> <rmKR5-7gk-41@gated-at.bofh.it> <rmKR5-7gk-43@gated-at.bofh.it> <rmKR5-7gk-35@gated-at.bofh.it>
Organization	ARM Ltd

Show all headers | View raw

Hi Vineet,

On 11/04/16 15:09, Vineet Gupta wrote:
> On Monday 11 April 2016 06:41 PM, Marc Zyngier wrote:
>>>>> It doesn't mean I really approve of it. The default domain thing is
>>>>> going to end-up biting you in the rear. But hey, better having this
>>>>> supported upstream than leaving these patches up in the air...
> 
> Hi Marc,
> 
> Aside of this - there's been serious rework of ARC intc / timers code spurred by
> some of your comments for this irqchip driver.
> 
> - We now probe timers via DT (so timer irq comes off of DT as well)
> - We have now switched to linear irq domain (vs. legacy)
> 
> IMHO a bunch of ugliness / non-desirability remains (there's likely more)
> - calling irq_set_default_host()
> - calling irq_create_mapping with NULL for IPIs
> 
> I really want to do things in better way - make it more modern ... hence would
> request you to please take a look at my latest series (I can post the patches here
> if that helps - although it felt I was spamming you and you got pissed off or
> something and were not responding of late :-)

No, it is just that my bandwidth has been max'd out over the past few
months. There is only so many patches I can look at while still being
able to write some code myself, and I may have flagged your emails as
"things to look at when I have time", which may not have happened in a
timely manner - sorry about that.

Just keep me on CC when you repost them, and I'll try to be a bit more
reactive.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v8 3/3] irqchip: add nps Internal and external irqchips Marc Zyngier <marc.zyngier@arm.com> - 2016-04-11 15:00 +0200
  Re: [PATCH v8 3/3] irqchip: add nps Internal and external irqchips Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2016-04-11 15:40 +0200
    Re: [PATCH v8 3/3] irqchip: add nps Internal and external irqchips Jason Cooper <jason@lakedaemon.net> - 2016-04-11 15:50 +0200
  Re: [PATCH v8 3/3] irqchip: add nps Internal and external irqchips Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2016-04-11 16:20 +0200
    Re: [PATCH v8 3/3] irqchip: add nps Internal and external irqchips Marc Zyngier <marc.zyngier@arm.com> - 2016-04-11 16:50 +0200

csiph-web