[PATCH] efi: Use GFP_ATOMIC instead of GFP_KERNEL

From	Vaishali Thakkar <vaishali.thakkar@oracle.com>
Newsgroups	linux.kernel
Subject	[PATCH] efi: Use GFP_ATOMIC instead of GFP_KERNEL
Date	2016-04-11 13:00 +0200
Message-ID	<rmHJv-4qq-5@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Function dup_variable_bug is called inside the spinlock.
This may lead to issues when kzalloc sleeps, so it is
better to use GFP_ATOMIC in this spinlocked context.

Problem found using Coccinelle.

Signed-off-by: Vaishali Thakkar <vaishali.thakkar@oracle.com>
---
 drivers/firmware/efi/vars.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/efi/vars.c b/drivers/firmware/efi/vars.c
index 0ac594c..d5e2f28 100644
--- a/drivers/firmware/efi/vars.c
+++ b/drivers/firmware/efi/vars.c
@@ -411,7 +411,7 @@ static void dup_variable_bug(efi_char16_t *str16, efi_guid_t *vendor_guid,
 	 */
 	efivar_wq_enabled = false;
 
-	str8 = kzalloc(len8, GFP_KERNEL);
+	str8 = kzalloc(len8, GFP_ATOMIC);
 	if (!str8)
 		return;
 
-- 
2.1.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] efi: Use GFP_ATOMIC instead of GFP_KERNEL Vaishali Thakkar <vaishali.thakkar@oracle.com> - 2016-04-11 13:00 +0200
  Re: [PATCH] efi: Use GFP_ATOMIC instead of GFP_KERNEL Matt Fleming <matt@codeblueprint.co.uk> - 2016-04-15 00:00 +0200
    Re: [PATCH] efi: Use GFP_ATOMIC instead of GFP_KERNEL Julia Lawall <julia.lawall@lip6.fr> - 2016-04-15 08:40 +0200

csiph-web