Re: [PATCH 1/2] mfd: max77693: Allow building as a module

Path	csiph.com!news.mixmin.net!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod
From	Lee Jones <lee.jones@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] mfd: max77693: Allow building as a module
Date	Fri, 08 Apr 2016 09:20:02 +0200
Message-ID	<rlyRY-eV-9@gated-at.bofh.it> (permalink)
References	<rk7Au-8hT-9@gated-at.bofh.it> <rlika-4wu-7@gated-at.bofh.it> <rlvKq-6c1-5@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=OOWtvosqFT/ixIW3oAWm37zzGt+rY/PPAhX76pF5pN4=; b=Ye46olIFBf6D6yqrwOrtmi4WZqFtCDm3knitzywPWa8Mvi+dDq+pSje1mpqVnbeN61 1v9d2W2MoA7y/0TY/Shr36LHzn2kkhaa3fqC290L8Cburn+mB29S5ImCX95qYb2tentr iU17Z3dgbxV5iykb/vGp7h9PalOePjd6x2+h4=
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=OOWtvosqFT/ixIW3oAWm37zzGt+rY/PPAhX76pF5pN4=; b=BQJoLXkEuuP8ZKwJdP9ZXjVlr4EPcdSwiqb1APlTvB82s5B0xWZgfK9QT0P6VGiiog XNuW2y9waHGSx4lywzA31L3VkwF+kiyrAgWiDYr2tPOJ7CnLHhKTBjckaYCRp2ZWvSlA rlvGt4ni9w01eCfjspTF7u30omjJiMiEEFO+sP10Zk0spblPozJagDAlZacqv3MOI+eH sHxK+w9E9Th08YuNNnGrgLabE9EdVXOHnBov2hsDkb8dECCkvEn7iLljL8Db2sQFNKNz wYbvGd5W0jpdv1eKQT8rk2QE94Xe2xeD5Sqyq4hnvpbMcDZbOj74XBAD7VGRI0ZYddVM zAzA==
X-Gm-Message-State	AD7BkJKn2lb6MyRhKOW5el9Ry40vMQIapKj6+ds7PT/bStEe4Bw6FziBkcLAU5z2RgL5C0AU
X-Received	by 10.28.17.198 with SMTP id 189mr1871044wmr.47.1460099844517; Fri, 08 Apr 2016 00:17:24 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=utf-8
Content-Disposition	inline
Content-Transfer-Encoding	8bit
User-Agent	Mutt/1.5.21 (2010-09-15)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	40
Organization	linux.* mail to news gateway
X-Original-Cc	Chanwoo Choi <cw00.choi@samsung.com>, Arnd Bergmann <arnd@arndb.de>, Javier Martinez Canillas <javier@osg.samsung.com>, Kukjin Kim <kgene@kernel.org>, Olof Johansson <olof@lixom.net>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Kevin Hilman <khilman@kernel.org>, Paul Gortmaker <paul.gortmaker@windriver.com>
X-Original-Date	Fri, 8 Apr 2016 08:17:21 +0100
X-Original-Message-ID	<20160408071721.GE3323@x1>
X-Original-References	<1459756459-22061-1-git-send-email-k.kozlowski@samsung.com> <20160407132947.GB3323@x1> <20160408035445.GA9532@kozik-lap>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1374029

Show key headers only | View raw

On Fri, 08 Apr 2016, Krzysztof Kozlowski wrote:

> On Thu, Apr 07, 2016 at 02:29:47PM +0100, Lee Jones wrote:
> > On Mon, 04 Apr 2016, Krzysztof Kozlowski wrote:
> > 
> > > The consumer of max77693 regulators on Trats2 board (samsung-usb2-phy
> > > driver) supports deferred probing so the max77693 main MFD driver can be
> > > built now as a module. This gives more flexibility and removes manual
> > > ordering of init calls.
> > > 
> > > Suggested-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> > > Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
> > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> > > ---
> > >  drivers/mfd/Kconfig    |  4 ++--
> > >  drivers/mfd/max77693.c | 14 ++------------
> > >  2 files changed, 4 insertions(+), 14 deletions(-)
> > 
> > I assume this can be taken immediately and doesn't depend on anything
> > external to the set?
> > 
> > For my own reference:
> >   Acked-by: Lee Jones <lee.jones@linaro.org>
> 
> Hi,
> 
> Yes, this can be taken as is. Only second patch (changing defconfig)
> depends on this. I can take the second patch through samsung tree but
> that would require a tag/branch with this... which looks like an
> overkill. So maybe you would take both?

If I take the defconfig patch without a tag, there will almost
certainly be merge conflicts.  Other solutions include; delaying the
defconfig patch for one cycle or trying to get it in post -rc1.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Thread

[PATCH 1/2] mfd: max77693: Allow building as a module Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-04 10:00 +0200
  Re: [PATCH 1/2] mfd: max77693: Allow building as a module Javier Martinez Canillas <javier@osg.samsung.com> - 2016-04-05 16:10 +0200
  Re: [PATCH 1/2] mfd: max77693: Allow building as a module Lee Jones <lee.jones@linaro.org> - 2016-04-07 15:40 +0200
    Re: [PATCH 1/2] mfd: max77693: Allow building as a module Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-08 06:00 +0200
      Re: [PATCH 1/2] mfd: max77693: Allow building as a module Lee Jones <lee.jones@linaro.org> - 2016-04-08 09:20 +0200
        Re: [PATCH 1/2] mfd: max77693: Allow building as a module Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-10 10:50 +0200
  Re: [PATCH 1/2] mfd: max77693: Allow building as a module Lee Jones <lee.jones@linaro.org> - 2016-04-11 10:10 +0200

csiph-web