Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1373629

[PATCH 3/9] net: mediatek: mtk_cal_txd_req() returns bad value

From John Crispin <blogic@openwrt.org>
Newsgroups linux.kernel
Subject [PATCH 3/9] net: mediatek: mtk_cal_txd_req() returns bad value
Date 2016-04-07 20:10 +0200
Message-ID <rlmxs-7V5-29@gated-at.bofh.it> (permalink)
References <rlmnM-7Av-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


The code used to also support the PDMA engine, which had 2 packet pointers
per descriptor. Because of this we had to divide the result by 2 and round
it up. This is no longer needed as the code only supports QDMA.

Signed-off-by: John Crispin <blogic@openwrt.org>
---
 drivers/net/ethernet/mediatek/mtk_eth_soc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
index bb10d57..94cceb8 100644
--- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
+++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
@@ -681,7 +681,7 @@ static inline int mtk_cal_txd_req(struct sk_buff *skb)
 		nfrags += skb_shinfo(skb)->nr_frags;
 	}
 
-	return DIV_ROUND_UP(nfrags, 2);
+	return nfrags;
 }
 
 static int mtk_start_xmit(struct sk_buff *skb, struct net_device *dev)
-- 
1.7.10.4

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

[PATCH 3/9] net: mediatek: mtk_cal_txd_req() returns bad value John Crispin <blogic@openwrt.org> - 2016-04-07 20:10 +0200

csiph-web