Re: [PATCH] staging: rtl8192u: remove blank lines after braces (opening)

From	Joe Perches <joe@perches.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] staging: rtl8192u: remove blank lines after braces (opening)
Date	2016-04-07 20:10 +0200
Message-ID	<rlmxr-7V5-9@gated-at.bofh.it> (permalink)
References	<rkBIf-6yB-17@gated-at.bofh.it> <rlmxr-7V5-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 2016-04-07 at 20:59 +0300, Andy Shevchenko wrote:
> On Tue, Apr 5, 2016 at 7:07 PM, Nicholas Sim <nicholassimws@gmail.com> wrote:
> > 
> > Remove unneeded blank lines appearing after opening braces as suggested
> > by checkpatch.pl
> > 
> You have to combine this with the rest so called 'indentation' fixes,
> e.g. +- empty lines, tabs vs. spaces, etc.

Actually, patches that do single things like removing
undesired blank lines are easier to review if separate
from patches that change horizontal whitespace.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] staging: rtl8192u: remove blank lines after braces (opening) Nicholas Sim <nicholassimws@gmail.com> - 2016-04-05 18:10 +0200
  Re: [PATCH] staging: rtl8192u: remove blank lines after braces (opening) Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-04-07 20:10 +0200
    Re: [PATCH] staging: rtl8192u: remove blank lines after braces (opening) Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-04-07 20:10 +0200
      Re: [PATCH] staging: rtl8192u: remove blank lines after braces  (opening) Joe Perches <joe@perches.com> - 2016-04-07 20:20 +0200
    Re: [PATCH] staging: rtl8192u: remove blank lines after braces  (opening) Joe Perches <joe@perches.com> - 2016-04-07 20:10 +0200

csiph-web